From: bfields@fieldses.org (J. Bruce Fields)
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: generic/495: swap on sparse file over NFS
Date: Mon, 23 Sep 2019 16:00:36 -0400 [thread overview]
Message-ID: <20190923200036.GA5085@fieldses.org> (raw)
I'm updating to a newer xfstests and seeing:
generic/495 - output mismatch (see
/root/xfstests-dev/results//generic/495.out.bad)
--- tests/generic/495.out 2019-09-18 17:28:00.834721480 -0400
+++ /root/xfstests-dev/results//generic/495.out.bad 2019-09-20 13:34:01.1568
89741 -0400
@@ -1,5 +1,4 @@
QA output created by 495
File with holes
-swapon: Invalid argument
Empty swap file (only swap header)
swapon: Invalid argument
If I understand correctly, it's requiring swapon to fail on a sparse
file, which isn't going to happen on NFS, where the sparsenes of the
file isn't really the client's concern.
Is it really correct to *require* swapon to fail in this case?
--b.
next reply other threads:[~2019-09-23 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 20:00 J. Bruce Fields [this message]
2019-09-23 20:21 ` generic/495: swap on sparse file over NFS Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923200036.GA5085@fieldses.org \
--to=bfields@fieldses.org \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).