From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
bfields@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v8 12/20] NFS: replace cross device check in copy_file_range
Date: Thu, 10 Oct 2019 08:46:14 -0400 [thread overview]
Message-ID: <20191010124622.27812-13-olga.kornievskaia@gmail.com> (raw)
In-Reply-To: <20191010124622.27812-1-olga.kornievskaia@gmail.com>
From: Olga Kornievskaia <kolga@netapp.com>
Add a check to disallow cross file systems copy offload, both
files are expected to be of NFS4.2+ type.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
fs/nfs/nfs4file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
index 8978325..e97813b 100644
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -141,7 +141,7 @@ static ssize_t __nfs4_copy_file_range(struct file *file_in, loff_t pos_in,
bool sync = false;
/* Only offload copy if superblock is the same */
- if (file_inode(file_in)->i_sb != file_inode(file_out)->i_sb)
+ if (file_in->f_op != &nfs4_file_operations)
return -EXDEV;
if (!nfs_server_capable(file_inode(file_out), NFS_CAP_COPY))
return -EOPNOTSUPP;
--
1.8.3.1
next prev parent reply other threads:[~2019-10-10 12:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 12:46 [PATCH v8 00/20] client and server support for "inter" SSC copy Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 01/20] NFS NFSD: defining nl4_servers structure needed by both Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 02/20] NFS: add COPY_NOTIFY operation Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 03/20] NFS: add ca_source_server<> to COPY Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 04/20] NFS: inter ssc open Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 05/20] NFS: skip recovery of copy open on dest server Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 06/20] NFS: for "inter" copy treat ESTALE as ENOTSUPP Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 07/20] NFS: COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 08/20] NFS: also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 09/20] NFS handle NFS4ERR_PARTNER_NO_AUTH error Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 10/20] NFS: handle source server reboot Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 11/20] NFS based on file size issue sync copy or fallback to generic copy offload Olga Kornievskaia
2019-10-10 12:46 ` Olga Kornievskaia [this message]
2019-10-10 12:46 ` [PATCH v8 13/20] NFSD fill-in netloc4 structure Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 14/20] NFSD add ca_source_server<> to COPY Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 15/20] NFSD COPY_NOTIFY xdr Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 16/20] NFSD add COPY_NOTIFY operation Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 17/20] NFSD check stateids against copy stateids Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 18/20] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 19/20] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia
2019-10-10 12:46 ` [PATCH v8 20/20] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010124622.27812-13-olga.kornievskaia@gmail.com \
--to=olga.kornievskaia@gmail.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).