From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Mao Wenan <maowenan@huawei.com>,
Bruce Fields <bfields@redhat.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Dros Adamson <dros@primarydata.com>,
jeff.layton@primarydata.com, richard.sharpe@primarydata.com,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
Date: Fri, 1 Nov 2019 17:49:21 +0300 [thread overview]
Message-ID: <20191101144921.GA10409@kadam> (raw)
In-Reply-To: <7E1B5E17-FF35-472B-8316-D4C01085BAE4@oracle.com>
On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> Hi Mao-
>
> > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
> >
> > The declarations were introduced with the file, but the declared
> > variables were not used.
> >
> > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
>
> I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> works fine without this change, and it's not something we
> would need to backport into stable kernels.
>
> This is more of a clean up patch.
>
Fixes is not really related to backports or stable. I would agree that
this isn't a bug but just a cleanup, but the problem is that other
people want Fixes tags for everything...
Yesterday I sent a cleanup patch and I almost put the Fixes tag under
the --- cut off but in the end I just deleted it... It's hard to know
what the right thing is.
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-01 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 11:40 [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used Mao Wenan
2019-11-01 13:36 ` Chuck Lever
2019-11-01 14:49 ` Dan Carpenter [this message]
2019-11-01 15:51 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101144921.GA10409@kadam \
--to=dan.carpenter@oracle.com \
--cc=bfields@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=dros@primarydata.com \
--cc=jeff.layton@primarydata.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=richard.sharpe@primarydata.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).