From: "J. Bruce Fields" <bfields@fieldses.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] nfsd: Fix races between nfsd4_cb_release() and nfsd4_shutdown_callback()
Date: Fri, 8 Nov 2019 12:51:09 -0500 [thread overview]
Message-ID: <20191108175109.GA758@fieldses.org> (raw)
In-Reply-To: <20191107222712.GB10806@fieldses.org>
On Thu, Nov 07, 2019 at 05:27:12PM -0500, J. Bruce Fields wrote:
> On Tue, Oct 29, 2019 at 05:47:05PM -0400, J. Bruce Fields wrote:
> > On Fri, Oct 25, 2019 at 11:33:36AM -0400, bfields wrote:
> > > On Fri, Oct 25, 2019 at 11:21:19AM -0400, J. Bruce Fields wrote:
> > > > I thought I was running v2, let me double-check....
> > >
> > > Yes, with v2 I'm getting a hang on generic/013.
> > >
> > > I checked quickly and didn't see anything interesting in the logs,
> > > otherwise I haven't done any digging.
> >
> > Reproduceable just with ./check -nfs generic/013. The last thing I see
> > in wireshark is an asynchronous COPY call and reply. Which means it's
> > probably trying to do a CB_OFFLOAD. Hm.
>
> Oh, I think it just needs the following.
Applying as follows, with part of the change split out into a separate
patch (since that's how I noticed the bug).
--b.
next prev parent reply other threads:[~2019-11-08 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 21:43 [PATCH v2] nfsd: Fix races between nfsd4_cb_release() and nfsd4_shutdown_callback() Trond Myklebust
2019-10-25 14:51 ` J. Bruce Fields
2019-10-25 14:55 ` Trond Myklebust
2019-10-25 15:21 ` J. Bruce Fields
2019-10-25 15:33 ` J. Bruce Fields
2019-10-29 21:47 ` J. Bruce Fields
2019-11-07 22:27 ` J. Bruce Fields
2019-11-08 17:51 ` J. Bruce Fields [this message]
2019-11-08 17:52 ` J. Bruce Fields
2019-11-08 17:54 ` [PATCH] nfsd: document callback_wq serialization of callback code J. Bruce Fields
2019-11-08 17:55 ` [PATCH] nfsd: mark cb path down on unknown errors J. Bruce Fields
2019-11-08 18:44 ` [PATCH v2] nfsd: Fix races between nfsd4_cb_release() and nfsd4_shutdown_callback() Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108175109.GA758@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).