From: Petr Vorel <pvorel@suse.cz>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: Olga Kornievskaia <olga.kornievskaia@gmail.com>,
trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFS: allow deprecation of NFS UDP protocol
Date: Fri, 22 Nov 2019 11:41:12 +0100 [thread overview]
Message-ID: <20191122104112.GB24235@dell5510> (raw)
In-Reply-To: <ce430173-8fc0-564a-eb51-f79698920436@oracle.com>
Hi Olga, Calum,
...
> > +config NFS_DISABLE_UDP_SUPPORT
> > + bool "NFS: Disable NFS UDP protocol support"
> > + depends on NFS_FS
> > + default y
> > + help
> > + Choose Y here to disable the use of NFS over UDP. NFS over UDP
> > + on modern networks (1Gb+) can lead to data corruption caused by
> > + fragmentation during high loads.
> > + The default is N because many deployments still use UDP.
> You've changed the default to 'y' for v2, but you've left in the 'N'
> comment.
+1
> > diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> > index 02110a3..24ca314 100644
> > --- a/fs/nfs/client.c
> > +++ b/fs/nfs/client.c
> > @@ -474,6 +474,7 @@ void nfs_init_timeout_values(struct rpc_timeout *to, int proto,
> > to->to_maxval = to->to_initval;
> > to->to_exponential = 0;
> > break;
> > +#ifdef CONFIG_NFS_DISABLE_UDP_SUPPORT
> > case XPRT_TRANSPORT_UDP:
> > if (retrans == NFS_UNSPEC_RETRANS)
> > to->to_retries = NFS_DEF_UDP_RETRANS;
> > @@ -484,6 +485,7 @@ void nfs_init_timeout_values(struct rpc_timeout *to, int proto,
> > to->to_maxval = NFS_MAX_UDP_TIMEOUT;
> > to->to_exponential = 1;
> > break;
> > +#endif
> Should the first two of your added ifdefs be ifndefs?
+1
...
Other changes LGTM.
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-22 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 16:06 [PATCH v2] NFS: allow deprecation of NFS UDP protocol Olga Kornievskaia
2019-11-21 23:16 ` Calum Mackay
2019-11-22 10:41 ` Petr Vorel [this message]
2019-11-24 2:15 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122104112.GB24235@dell5510 \
--to=pvorel@suse.cz \
--cc=anna.schumaker@netapp.com \
--cc=calum.mackay@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).