linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org, Joey Hess <joeyh@debian.org>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [nfs-utils PATCH 1/1] mount: Do not overwrite /etc/mtab if it's symlink
Date: Fri, 22 Nov 2019 17:27:08 +0100	[thread overview]
Message-ID: <20191122162708.GB4477@dell5510> (raw)
In-Reply-To: <938c3cf9-0584-d6b9-b3a1-ec12795761c5@RedHat.com>

Hi Steve,

> On 11/20/19 1:35 PM, Petr Vorel wrote:
> > From: Joey Hess <joeyh@debian.org>

> > Some systems have /etc/mtab symlink to /proc/mounts. In that case
> > mount.nfs complains:
> > Can't set permissions on mtab: Operation not permitted

> > See https://bugs.debian.org/476577

> > This change makes mount.nfs handle symlinked /etc/mtab the way
> > umount.nfs and util- linux handle it.

> > Cc: Chuck Lever <chuck.lever@oracle.com>
> > Signed-off-by: Joey Hess <joeyh@debian.org>
> > [ pvorel: took patch from Debian, rebased for 2.4.3-rc1 and created commit
> > message. Patch is also used in Gentoo. ]
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> Committed... (tag: nfs-utils-2-4-3-rc2)
I'm sorry for introducing a regression.

Send a patch fixing this.
https://patchwork.kernel.org/patch/11258155/

> steved.

Kind regards,
Petr

      reply	other threads:[~2019-11-22 16:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 18:35 [nfs-utils PATCH 1/1] mount: Do not overwrite /etc/mtab if it's symlink Petr Vorel
2019-11-20 18:51 ` Chuck Lever
2019-11-22 15:49 ` Steve Dickson
2019-11-22 16:27   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122162708.GB4477@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=SteveD@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=joeyh@debian.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).