From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7594FC2D0C1 for ; Fri, 6 Dec 2019 14:39:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CA7C20706 for ; Fri, 6 Dec 2019 14:39:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BK4nTEoX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726195AbfLFOjz (ORCPT ); Fri, 6 Dec 2019 09:39:55 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:45704 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726509AbfLFOjz (ORCPT ); Fri, 6 Dec 2019 09:39:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575643194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s6MwTaVIzd8C+aMGsohjXU9Q65/lFnu2IUuINQNlcCc=; b=BK4nTEoXeBuizmPLaVg/8zMZAwAeI9b1esHQoBea4PUScwtS75Iap7nU3JHW7Fg+PTm/6f OZdDAvjhUfAutOAj7AoskWWNY/qqb4l0yeFefsiaMs1sOcx0krKey+aQ9EF1B0oBLNoYED J5gDit5Ppt4TtlBnK1i68qGGgAtVN+o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-MJ4ROBaJNlKAmT4D_ET7hA-1; Fri, 06 Dec 2019 09:39:53 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 251A6107ACCA; Fri, 6 Dec 2019 14:39:51 +0000 (UTC) Received: from coeurl.usersys.redhat.com (ovpn-123-90.rdu2.redhat.com [10.10.123.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FA0719C7F; Fri, 6 Dec 2019 14:39:48 +0000 (UTC) Received: by coeurl.usersys.redhat.com (Postfix, from userid 1000) id 00C86209A8; Fri, 6 Dec 2019 09:39:47 -0500 (EST) Date: Fri, 6 Dec 2019 09:39:47 -0500 From: Scott Mayhew To: anna.schumaker@netapp.com, trond.myklebust@hammerspace.com Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/27] nfs: Mount API conversion Message-ID: <20191206143947.GV4276@coeurl.usersys.redhat.com> References: <20191120152750.6880-1-smayhew@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191120152750.6880-1-smayhew@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: MJ4ROBaJNlKAmT4D_ET7hA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Anna, Trond, Have you had a chance to look at these? Do you have any comments? I do have a small fix to make to nfs4_validate_fspath() for an issue that Dan Carpenter reported, but I was waiting to see if there was anything else. -Scott On Wed, 20 Nov 2019, Scott Mayhew wrote: > Hi Trond, Anna, >=20 > Here's a set of patches that converts NFS to use the mount API. Note tha= t > there are a lot of preliminary patches, some from David and some from Al. > The final patch (the one that does the actual conversion) from the David'= s > initial posting has been split into 5 separate patches, and the entire se= t > has been rebased on top of 5.4-rc8. >=20 > Changes since v4: > - further split the original "NFS: Add fs_context support" patch (new > patch is about 25% smaller than the v4 patch) > - fixed NFSv4 referral mounts (broken in the original patch) > - fixed leak of nfs_fattr when fs_context is freed > Changes since v3: > - changed license and copyright text in fs/nfs/fs_context.c > Changes since v2: > - fixed the conversion of the nconnect=3D option > - added '#if IS_ENABLED(CONFIG_NFS_V4)' around nfs4_parse_monolithic() > to avoid unused-function warning when compiling with v4 disabled > Chagnes since v1: > - split up patch 23 into 4 separate patches >=20 > -Scott >=20 > Al Viro (15): > saner calling conventions for nfs_fs_mount_common() > nfs: stash server into struct nfs_mount_info > nfs: lift setting mount_info from nfs4_remote{,_referral}_mount > nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type > nfs: don't bother setting/restoring export_path around > do_nfs_root_mount() > nfs4: fold nfs_do_root_mount/nfs_follow_remote_path > nfs: lift setting mount_info from nfs_xdev_mount() > nfs: stash nfs_subversion reference into nfs_mount_info > nfs: don't bother passing nfs_subversion to ->try_mount() and > nfs_fs_mount_common() > nfs: merge xdev and remote file_system_type > nfs: unexport nfs_fs_mount_common() > nfs: don't pass nfs_subversion to ->create_server() > nfs: get rid of mount_info ->fill_super() > nfs_clone_sb_security(): simplify the check for server bogosity > nfs: get rid of ->set_security() >=20 > David Howells (8): > NFS: Move mount parameterisation bits into their own file > NFS: Constify mount argument match tables > NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context > NFS: Split nfs_parse_mount_options() > NFS: Deindent nfs_fs_context_parse_option() > NFS: Add a small buffer in nfs_fs_context to avoid string dup > NFS: Do some tidying of the parsing code > NFS: Add fs_context support. >=20 > Scott Mayhew (4): > NFS: rename nfs_fs_context pointer arg in a few functions > NFS: Convert mount option parsing to use functionality from > fs_parser.h > NFS: Additional refactoring for fs_context conversion > NFS: Attach supplementary error information to fs_context. >=20 > fs/nfs/Makefile | 2 +- > fs/nfs/client.c | 80 +- > fs/nfs/fs_context.c | 1424 +++++++++++++++++++++++++ > fs/nfs/fscache.c | 2 +- > fs/nfs/getroot.c | 73 +- > fs/nfs/internal.h | 132 +-- > fs/nfs/namespace.c | 144 ++- > fs/nfs/nfs3_fs.h | 2 +- > fs/nfs/nfs3client.c | 6 +- > fs/nfs/nfs3proc.c | 2 +- > fs/nfs/nfs4_fs.h | 9 +- > fs/nfs/nfs4client.c | 99 +- > fs/nfs/nfs4namespace.c | 291 ++--- > fs/nfs/nfs4proc.c | 2 +- > fs/nfs/nfs4super.c | 257 ++--- > fs/nfs/proc.c | 2 +- > fs/nfs/super.c | 2219 +++++---------------------------------- > include/linux/nfs_xdr.h | 9 +- > 18 files changed, 2283 insertions(+), 2472 deletions(-) > create mode 100644 fs/nfs/fs_context.c >=20 > --=20 > 2.17.2 >=20