From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB04C33C8C for ; Mon, 6 Jan 2020 16:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FCBB208C4 for ; Mon, 6 Jan 2020 16:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aOWkfbIQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbgAFQ3C (ORCPT ); Mon, 6 Jan 2020 11:29:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41833 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726677AbgAFQ3C (ORCPT ); Mon, 6 Jan 2020 11:29:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578328141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dWZzCo0dL1t3oBL+mRxnfhduXRW4GvQOIUYTk1rT7zk=; b=aOWkfbIQ9dFuGvqkhyEJq2KM69wp1i4rCcXL5XuxsLlnwhy6/KKrJ2UaYkQNlKhMrOBACo FUqCPH0KdBP1ZX9pvk1OKQ8Ep2Y9M3QKAxeu7BQ1hEMmbKBYTWmOMrMkrF0T86GguW6o0d Ay/Cyhg8zWhEMgkGUQzN3WzjfHE7ytQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-5o_xm6yvM4OHFzWq3DrMOQ-1; Mon, 06 Jan 2020 11:28:58 -0500 X-MC-Unique: 5o_xm6yvM4OHFzWq3DrMOQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E3F218552DF; Mon, 6 Jan 2020 16:28:57 +0000 (UTC) Received: from pick.fieldses.org (ovpn-126-209.rdu2.redhat.com [10.10.126.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7B1E10840F5; Mon, 6 Jan 2020 16:28:56 +0000 (UTC) Received: by pick.fieldses.org (Postfix, from userid 2815) id 9E8D7120198; Mon, 6 Jan 2020 11:28:54 -0500 (EST) Date: Mon, 6 Jan 2020 11:28:54 -0500 From: "J. Bruce Fields" To: "J. R. Okajima" Cc: trond.myklebust@hammerspace.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH]: nfs acl: bugfix, don't use static nfsd_acl_versions[] Message-ID: <20200106162854.GA25029@pick.fieldses.org> References: <29104.1578242282@jrobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29104.1578242282@jrobl> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Thanks, but, see 7c149057d044 "nfsd: restore NFSv3 ACL support", in 5.5-rc1; looks like you and I both stumbled on the identical fix?--b. On Mon, Jan 06, 2020 at 01:38:02AM +0900, J. R. Okajima wrote: > Here is a patch to fix nfs acl. > > J. R. Okajima > > ---------------------------------------- > commit 8684b9a7c55e9283e8b21112fbdf19b4d27f36b7 > Author: J. R. Okajima > Date: Mon Jan 6 01:31:20 2020 +0900 > > nfs acl: bugfix, don't use static nfsd_acl_versions[] > > By the commit for v5.2-rc1, > e333f3bbefe3 2019-04-24 nfsd: Allow containers to set supported nfs versions > the line to copy a value from nfsd_acl_version[] to static > nfsd_acl_versions[] was removed. It is OK, but nfsd_acl_versions[] is > still set to nfsd_acl_program.pg_vers which means pg_vers has NULLs for > its all entires and nfsacl stops working entirely. > I am afraid the removal of static nfsd_acl_versions[] was just > forgotten. > > Signed-off-by: J. R. Okajima > > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c > index 18d94ea984ba..7f938bcb927d 100644 > --- a/fs/nfsd/nfssvc.c > +++ b/fs/nfsd/nfssvc.c > @@ -94,12 +94,11 @@ static const struct svc_version *nfsd_acl_version[] = { > > #define NFSD_ACL_MINVERS 2 > #define NFSD_ACL_NRVERS ARRAY_SIZE(nfsd_acl_version) > -static const struct svc_version *nfsd_acl_versions[NFSD_ACL_NRVERS]; > > static struct svc_program nfsd_acl_program = { > .pg_prog = NFS_ACL_PROGRAM, > .pg_nvers = NFSD_ACL_NRVERS, > - .pg_vers = nfsd_acl_versions, > + .pg_vers = nfsd_acl_version, > .pg_name = "nfsacl", > .pg_class = "nfsd", > .pg_stats = &nfsd_acl_svcstats, >