Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic/529: use an ACL that doesn't confuse NFS
@ 2019-12-19 22:33 bfields
  2020-01-07 11:41 ` Murphy Zhou
  0 siblings, 1 reply; 2+ messages in thread
From: bfields @ 2019-12-19 22:33 UTC (permalink / raw)
  To: fstests; +Cc: linux-nfs

From: "J. Bruce Fields" <bfields@redhat.com>

For historical reasons having to do with Solaris ACL behavior, the Linux
client treats an ACL like the one used as an example here as equivalent
to a mode, causing listxattr to report that no ACL is set on the file.

(See the comment at the top of fs/nfs_common/nfsacl.c in the kernel
source for details, and the "bogus ACL_MASK entry" comment in the same
source file.)  This causes a spurious generic/529 failure on NFS.

As far as I can tell any ACL should trigger the original XFS problem.
So, modify it so as not to hit this odd NFS corner case.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 src/t_attr_corruption.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/t_attr_corruption.c b/src/t_attr_corruption.c
index e7d435b1791f..b5513d44a288 100644
--- a/src/t_attr_corruption.c
+++ b/src/t_attr_corruption.c
@@ -59,7 +59,7 @@ int main(int argc, char *argv[])
 		.e = {
 			{htole16(1), 0, 0},
 			{htole16(4), 0, 0},
-			{htole16(0x10), 0, 0},
+			{htole16(0x10), htole16(4), 0},
 			{htole16(0x20), 0, 0},
 		},
 	};
-- 
2.24.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] generic/529: use an ACL that doesn't confuse NFS
  2019-12-19 22:33 [PATCH] generic/529: use an ACL that doesn't confuse NFS bfields
@ 2020-01-07 11:41 ` Murphy Zhou
  0 siblings, 0 replies; 2+ messages in thread
From: Murphy Zhou @ 2020-01-07 11:41 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: fstests, linux-nfs

On Thu, Dec 19, 2019 at 05:33:36PM -0500, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> For historical reasons having to do with Solaris ACL behavior, the Linux
> client treats an ACL like the one used as an example here as equivalent
> to a mode, causing listxattr to report that no ACL is set on the file.
> 
> (See the comment at the top of fs/nfs_common/nfsacl.c in the kernel
> source for details, and the "bogus ACL_MASK entry" comment in the same
> source file.)  This causes a spurious generic/529 failure on NFS.

Thanks Bruce very much for the fix!

Murphy

> 
> As far as I can tell any ACL should trigger the original XFS problem.
> So, modify it so as not to hit this odd NFS corner case.
> 
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
>  src/t_attr_corruption.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/t_attr_corruption.c b/src/t_attr_corruption.c
> index e7d435b1791f..b5513d44a288 100644
> --- a/src/t_attr_corruption.c
> +++ b/src/t_attr_corruption.c
> @@ -59,7 +59,7 @@ int main(int argc, char *argv[])
>  		.e = {
>  			{htole16(1), 0, 0},
>  			{htole16(4), 0, 0},
> -			{htole16(0x10), 0, 0},
> +			{htole16(0x10), htole16(4), 0},
>  			{htole16(0x20), 0, 0},
>  		},
>  	};
> -- 
> 2.24.1
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 22:33 [PATCH] generic/529: use an ACL that doesn't confuse NFS bfields
2020-01-07 11:41 ` Murphy Zhou

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git