Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mountd: Remove outdated/misleading comment
@ 2020-01-07 21:19 Christian Bartolomäus
  2020-01-16 20:49 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Bartolomäus @ 2020-01-07 21:19 UTC (permalink / raw)
  To: linux-nfs

It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
("mountd: fix mount issue due to comparison with uninitialized uuid") was
applied back in 2015. The final case of the switch statement no longer ends
with a 'return true' and the final 'return false' is relevant now.

Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
---
 utils/mountd/cache.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index e5186c7..8f54e37 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
 				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
 					return true;
 	}
-	/* Well, unreachable, actually: */
 	return false;
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mountd: Remove outdated/misleading comment
  2020-01-07 21:19 [PATCH] mountd: Remove outdated/misleading comment Christian Bartolomäus
@ 2020-01-16 20:49 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2020-01-16 20:49 UTC (permalink / raw)
  To: Christian Bartolomäus, linux-nfs



On 1/7/20 4:19 PM, Christian Bartolomäus wrote:
> It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
> ("mountd: fix mount issue due to comparison with uninitialized uuid") was
> applied back in 2015. The final case of the switch statement no longer ends
> with a 'return true' and the final 'return false' is relevant now.
> 
> Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
Committed... (tag: nfs-utils-2-4-3-rc5)

steved.

> ---
>  utils/mountd/cache.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index e5186c7..8f54e37 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
>  				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
>  					return true;
>  	}
> -	/* Well, unreachable, actually: */
>  	return false;
>  }
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 21:19 [PATCH] mountd: Remove outdated/misleading comment Christian Bartolomäus
2020-01-16 20:49 ` Steve Dickson

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git