Hi Trond, I love your patch! Yet something to improve: [auto build test ERROR on nfs/linux-next] [also build test ERROR on v5.5-rc6] [cannot apply to next-20200116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Trond-Myklebust/NFS-Add-softreval-behaviour-to-nfs_lookup_revalidate/20200115-140930 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next config: riscv-allmodconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from fs/nfs/blocklayout/blocklayout.c:43:0: fs/nfs/blocklayout/../internal.h: In function 'nfs_lookup_is_soft_revalidate': >> fs/nfs/blocklayout/../internal.h:36:38: error: 'NFS_MOUNT_SOFTREVAL' undeclared (first use in this function); did you mean 'NFS_MOUNT_SOFTERR'? if (!(NFS_SB(dentry->d_sb)->flags & NFS_MOUNT_SOFTREVAL)) ^~~~~~~~~~~~~~~~~~~ NFS_MOUNT_SOFTERR fs/nfs/blocklayout/../internal.h:36:38: note: each undeclared identifier is reported only once for each function it appears in vim +36 fs/nfs/blocklayout/../internal.h 33 34 static inline bool nfs_lookup_is_soft_revalidate(const struct dentry *dentry) 35 { > 36 if (!(NFS_SB(dentry->d_sb)->flags & NFS_MOUNT_SOFTREVAL)) 37 return false; 38 if (!d_is_positive(dentry) || !NFS_FH(d_inode(dentry))->size) 39 return false; 40 return true; 41 } 42 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation