linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	linux-nfs@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [nfs-utils PATCH 0/3] bump rpcgen version and silence some warning
Date: Sun, 19 Jan 2020 19:45:01 +0100	[thread overview]
Message-ID: <20200119184501.GA11432@dell5510> (raw)
In-Reply-To: <818c66c5-6f8b-927f-229e-52a00f50c682@RedHat.com>

Hi all,

> On 1/17/20 1:30 AM, Petr Vorel wrote:
> >>> If you have the chance to commit before releasing version it would be great!
> >> Your patch on my radar... but... conflicts  with Petr's cross-compilation patch
> >> https://lore.kernel.org/linux-nfs/20200114183603.GA24556@dell5510/T/#t

> >> That patch causes an automake warnings which is something I'm trying to avoid.

> >> No worries... I will not do a release w/out your patch.... or something close to it. 

> > Giulio, thanks for your patch. I'll have a look on it over a weekend.
> > Maybe Mike's cross-compilation patch is really not needed.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>
NOTE: as I understand it's a compilation issue of a tool, so I didn't run
rpcgen, I just test various compilation variants.

Considering recently merged Giulio's change in tools/rpcgen/Makefile.am
e61775d1 ("rpcgen: bump to latest version") I'm for trying this one.

I tested buildroot compilation of Giulio's changes [1] [2] and it works.
Notable change is to move from nfs-utils' internal rpcgen to external one from system
(replace --with-rpcgen=internal with --with-rpcgen=$(HOST_DIR)/bin/rpcgen in [2]).
IMHO Mike's patch is not needed for buildroot.

@Mike, could you please test it for Gentoo?

Looking at Gentoo package history, all packages [3] [4] [5] use rpcgen from system
(--with-rpcgen). This change was added 2 years ago for, nfs-utils 2.3.x [6];
but Mike's patch was here at least 5 years ago [7], for nfs-utils 1.2.x and
1.3.x (actually sent to ML in 2013-03-25 [8], so for 1.2.x?), so the patch might
not be needed any more since then anyway.

BTW NEWS file for nfs-utils 1.1.0 states that by default use rpcgen from system,
so it looks to me that at the time of Mike's patch needed for Gentoo it was also
using internal rpcgen, but maybe I'm wrong.

Kind regards,
Petr

[1] https://github.com/giuliobenetti/nfs-utils/commit/c45edd7a5d5aa51c735017a7fd4fd89948ad05b2
[2] https://github.com/giuliobenetti/buildroot/commit/e4ae0d0e33e61858701bfe44e9777f7c69584706
[3] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.3.4.ebuild
[4] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.4.1-r4.ebuild
[5] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.4.2-r1.ebuild
[6] https://gitweb.gentoo.org/repo/gentoo.git/commit/net-fs/nfs-utils?id=d3c1580e4b5e583a457055f1a01818269e65459f
[7] https://gitweb.gentoo.org/repo/gentoo.git/commit/net-fs/nfs-utils?id=56bd759df1d0c750a065b8c845e93d5dfa6b549d
[8] https://lore.kernel.org/linux-nfs/1364163668-15490-1-git-send-email-vapier@gentoo.org/

      reply	other threads:[~2020-01-19 18:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 16:29 [nfs-utils PATCH 0/3] bump rpcgen version and silence some warning Giulio Benetti
2020-01-13 16:29 ` [nfs-utils PATCH 2/3] rpcgen: rpc_cout: silence format-nonliteral Giulio Benetti
2020-01-13 16:29 ` [nfs-utils PATCH 3/3] support: nfs: rpc_socket: silence unused parameter warning on salen Giulio Benetti
2020-01-16 20:37 ` [nfs-utils PATCH 0/3] bump rpcgen version and silence some warning Steve Dickson
2020-01-16 20:41   ` Giulio Benetti
2020-01-16 20:44     ` Giulio Benetti
2020-01-16 21:08       ` Steve Dickson
2020-01-17  6:30         ` Petr Vorel
2020-01-17 14:32           ` Steve Dickson
2020-01-19 18:45             ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200119184501.GA11432@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=SteveD@redhat.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).