From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-rdma@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3] nfsd: Fix NFSv4 READ on RDMA when using readv
Date: Tue, 4 Feb 2020 14:17:25 -0500 [thread overview]
Message-ID: <20200204191725.GA10811@fieldses.org> (raw)
In-Reply-To: <B95D88FC-C76D-42A2-9366-CA226757BA42@oracle.com>
On Tue, Feb 04, 2020 at 01:43:56PM -0500, Chuck Lever wrote:
>
>
> > On Feb 4, 2020, at 12:21 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Sat, Feb 01, 2020 at 03:05:19PM -0500, Chuck Lever wrote:
> >> Changes since RFC2:
> >> - Take Trond's suggestion to use xdr->buf->len
> >> - Squash fix down to a single patch
> >
> > I liked them better split out.
> >
> > This seems fine to me, though.
> >
> > Could you ping me again in another week, after the merge window?
> >
> >> @@ -3521,17 +3521,14 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> >> u32 zzz = 0;
> >> int pad;
> >>
> >> + /* Ensure xdr_reserve_space skips past xdr->buf->head */
> >
> > Could the comment explain why we're doing this? (Maybe take some
> > language from the changelog.)
>
> The new comment will also explain why the patches are combined.
> I'll send a v4 after the merge window closes.
Hah, OK, thanks!
--b.
prev parent reply other threads:[~2020-02-04 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 20:05 [PATCH v3] nfsd: Fix NFSv4 READ on RDMA when using readv Chuck Lever
2020-02-04 17:21 ` J. Bruce Fields
2020-02-04 18:43 ` Chuck Lever
2020-02-04 19:17 ` Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204191725.GA10811@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).