linux-next: Fixes tag needs some work in the nfs-anna tree

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

In commit

  049a9d8a9117 ("NFSv4.1 fix rpc_call_done assignment for BIND_CONN_TO_SESSION")

Fixes tag

  Fixes: 02a95dee8 ("NFS add callback_ops to nfs4_proc_bind_conn_to_session_callback")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  4788db30d973 ("NFS: Fix O_DIRECT locking issues")

Fixes tag

  Fixes: 0703dc52ef0b ("NFS: Fix error handling for O_DIRECT write scheduling")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 954998b60caa ("NFS: Fix error handling for O_DIRECT write scheduling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  a3569716d183 ("xprtrdma: Fix uninitialized variable")

Fixes tag

  Fixes: 6919549677909c ('xprtrdma: MR-related memory allocation should be allowed to fail')

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d8cf39a280c3 ("xprtrdma: MR-related memory allocation should be allowed to fail")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi all,

In commit

  677c0cebca78 ("NFS: Fix initialisation of nfs_client cl_flags field")

Fixes tag

  Fixes: 87871d990a2c ("NFSv4: Initialise connection to the server in nfs4_alloc_client()")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: dd99e9f98fbf ("NFSv4: Initialise connection to the server in nfs4_alloc_client()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi all,

In commit

  b7ade38165ca ("sunrpc: fixed rollback in rpc_gssd_dummy_populate()")

Fixes tag

  Fixes: commit 4b9a445e3eeb ("sunrpc: create a new dummy pipe for gssd to hold open")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

In commit

  4609f9894ead ("SUNRPC: The TCP back channel mustn't disappear while requests are outstanding")

Fixes tag

  Fixes: 2ea24497a1b3 ("SUNRPC: RPC callbacks may be split across several..")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  ec6017d90359 ("SUNRPC fix regression in umount of a secure mount")

Fixes tag

  Fixes: c8485e4d63 ("SUNRPC: Handle ECONNREFUSED correctly in xprt_transmit()")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the nfs-anna tree

[Chuck Lever]

On Jan 15, 2019, at 6:38 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:

> [Re: linux-next: Fixes tag needs some work in the nfs-anna tree] On 15/01/2019 (Tue 23:12) Takashi Iwai wrote:
> 
>> On Tue, 15 Jan 2019 22:41:21 +0100,
>> Chuck Lever wrote:
>>> 
>>> Hi Stephen-
>>> 
>>> On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> 
>>>> [I am experimenting with checking the Fixes tags in commits in linux-next.
>>>> Please let me know if you think I am being too strict.]
>>>> 
>>>> Hi all,
>>>> 
>>>> Commit
>>>> 
>>>> deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
>>>> 
>>>> has problem with this Fixes tag:
>>>> 
>>>> Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
>>>> 
>>>> The subject should match the subject of the fixed commit.
>>>> 
>>>> -- 
>>>> Cheers,
>>>> Stephen Rothwell
>>> 
>>> I shortened the commit title so that the Fixes: line is shorter than 68
>>> characters. I can leave these titles alone if that's preferred.
>> 
>> I've sometimes shorted the subject like the above, too, as I find a
>> too long text annoying.  Maybe the partial string matching should
>> suffice, especially when it ends with "..." ?
> 
> The problem is consistency.  Perhaps you shorten at four words.  A
> person searches with five words or 70 chars -  they never see your commit.
> 
> The idea of consistency across the "Fixes:" tags is to allow a level of
> automated processing so that the creators of the stable releases can do
> a lot less manual hands-on processing.  They have enough work to do.

My impression was the scripted processing here relies on the commit
ID and not on the patch short description.

The convention of shortening the description with an ellipsis is
already widely used. I think it's reasonable to allow it.


--
Chuck Lever

Re: linux-next: Fixes tag needs some work in the nfs-anna tree

[Takashi Iwai]

On Wed, 16 Jan 2019 00:38:11 +0100,
Paul Gortmaker wrote:
> 
> [Re: linux-next: Fixes tag needs some work in the nfs-anna tree] On 15/01/2019 (Tue 23:12) Takashi Iwai wrote:
> 
> > On Tue, 15 Jan 2019 22:41:21 +0100,
> > Chuck Lever wrote:
> > > 
> > > Hi Stephen-
> > > 
> > > On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > 
> > > > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > > > Please let me know if you think I am being too strict.]
> > > > 
> > > > Hi all,
> > > > 
> > > > Commit
> > > > 
> > > >  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> > > > 
> > > > has problem with this Fixes tag:
> > > > 
> > > >  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> > > > 
> > > > The subject should match the subject of the fixed commit.
> > > > 
> > > > -- 
> > > > Cheers,
> > > > Stephen Rothwell
> > > 
> > > I shortened the commit title so that the Fixes: line is shorter than 68
> > > characters. I can leave these titles alone if that's preferred.
> > 
> > I've sometimes shorted the subject like the above, too, as I find a
> > too long text annoying.  Maybe the partial string matching should
> > suffice, especially when it ends with "..." ?
> 
> The problem is consistency.  Perhaps you shorten at four words.  A
> person searches with five words or 70 chars -  they never see your commit.

What's the reason to search for words instead of commit ID?

> The idea of consistency across the "Fixes:" tags is to allow a level of
> automated processing so that the creators of the stable releases can do
> a lot less manual hands-on processing.  They have enough work to do.

Yes, I know, but the important point for stable pick-up is the
correctness of the commit ID, no?

I can understand the need for validity check of the Fixes tag,
especially to check whether the given commit ID is really correct, in
linux-next stage.  But this can be verified even with a partial string
match.


thanks,

Takashi

Re: linux-next: Fixes tag needs some work in the nfs-anna tree

[Paul Gortmaker]

[Re: linux-next: Fixes tag needs some work in the nfs-anna tree] On 15/01/2019 (Tue 23:12) Takashi Iwai wrote:

> On Tue, 15 Jan 2019 22:41:21 +0100,
> Chuck Lever wrote:
> > 
> > Hi Stephen-
> > 
> > On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > > Please let me know if you think I am being too strict.]
> > > 
> > > Hi all,
> > > 
> > > Commit
> > > 
> > >  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> > > 
> > > has problem with this Fixes tag:
> > > 
> > >  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> > > 
> > > The subject should match the subject of the fixed commit.
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> > 
> > I shortened the commit title so that the Fixes: line is shorter than 68
> > characters. I can leave these titles alone if that's preferred.
> 
> I've sometimes shorted the subject like the above, too, as I find a
> too long text annoying.  Maybe the partial string matching should
> suffice, especially when it ends with "..." ?

The problem is consistency.  Perhaps you shorten at four words.  A
person searches with five words or 70 chars -  they never see your commit.

The idea of consistency across the "Fixes:" tags is to allow a level of
automated processing so that the creators of the stable releases can do
a lot less manual hands-on processing.  They have enough work to do.

Thanks,
Paul.
--

> 
> 
> thanks,
> 
> Takashi

Re: linux-next: Fixes tag needs some work in the nfs-anna tree

[Takashi Iwai]

On Tue, 15 Jan 2019 22:41:21 +0100,
Chuck Lever wrote:
> 
> Hi Stephen-
> 
> On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > Please let me know if you think I am being too strict.]
> > 
> > Hi all,
> > 
> > Commit
> > 
> >  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> > 
> > has problem with this Fixes tag:
> > 
> >  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> > 
> > The subject should match the subject of the fixed commit.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> I shortened the commit title so that the Fixes: line is shorter than 68
> characters. I can leave these titles alone if that's preferred.

I've sometimes shorted the subject like the above, too, as I find a
too long text annoying.  Maybe the partial string matching should
suffice, especially when it ends with "..." ?


thanks,

Takashi

Re: linux-next: Fixes tag needs some work in the nfs-anna tree

[Chuck Lever]

Hi Stephen-

On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> [I am experimenting with checking the Fixes tags in commits in linux-next.
> Please let me know if you think I am being too strict.]
> 
> Hi all,
> 
> Commit
> 
>  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> 
> has problem with this Fixes tag:
> 
>  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> 
> The subject should match the subject of the fixed commit.
> 
> -- 
> Cheers,
> Stephen Rothwell

I shortened the commit title so that the Fixes: line is shorter than 68
characters. I can leave these titles alone if that's preferred.


--
Chuck Lever

linux-next: Fixes tag needs some work in the nfs-anna tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

[I am experimenting with checking the Fixes tags in commits in linux-next.
Please let me know if you think I am being too strict.]

Hi all,

Commit

  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")

has problem with this Fixes tag:

  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")

The subject should match the subject of the fixed commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]