From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD16EC433E1 for ; Thu, 21 May 2020 08:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C1F92070A for ; Thu, 21 May 2020 08:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728655AbgEUIer (ORCPT ); Thu, 21 May 2020 04:34:47 -0400 Received: from verein.lst.de ([213.95.11.211]:53663 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728571AbgEUIer (ORCPT ); Thu, 21 May 2020 04:34:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2946668BEB; Thu, 21 May 2020 10:34:43 +0200 (CEST) Date: Thu, 21 May 2020 10:34:42 +0200 From: Christoph Hellwig To: Marcelo Ricardo Leitner Cc: David Miller , hch@lst.de, kuba@kernel.org, edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, vyasevich@gmail.com, nhorman@tuxdriver.com, jmaloy@redhat.com, ying.xue@windriver.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-ID: <20200521083442.GA7771@lst.de> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> <20200520233913.GV2491@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520233913.GV2491@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, May 20, 2020 at 08:39:13PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > > From: Marcelo Ricardo Leitner > > Date: Wed, 20 May 2020 20:10:01 -0300 > > > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > > API could be a bit more complete than that. > > > > The APIs are being designed based upon what in-tree users actually > > make use of. We can expand things later if necessary. > > Sometimes expanding things later can be though, thus why the worry. > But ok, I get it. Thanks. > > The comment still applies, though. (re the duplication) Where do you see duplication? sctp_setsockopt_nodelay does the following things: - verifies optlen, returns -EINVAL if it doesn't match - calls get_user, returns -EFAULT on error - converts the value from get_user to a boolean and assigns it to sctp_sk(sk)->nodelay - returns 0. sctp_sock_set_nodelay does: - call lock_sock - assign true to sctp_sk(sk)->nodelay - call release_sock - does not return an error code