From: Petr Vorel <pvorel@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"alexey.kodanev@oracle.com" <alexey.kodanev@oracle.com>,
"yangx.jy@cn.fujitsu.com" <yangx.jy@cn.fujitsu.com>,
Cyril Hrubis <chrubis@suse.cz>, Yong Sun <yosun@suse.com>
Subject: Re: [RFC PATCH 1/1] Remove nfsv4
Date: Tue, 21 Jul 2020 11:31:15 +0200 [thread overview]
Message-ID: <20200721093115.GB1164@dell5510> (raw)
In-Reply-To: <20200720181658.GA32123@dell5510>
Hi Christoph,
> > On Mon, Jul 20, 2020 at 01:32:09PM +0000, Trond Myklebust wrote:
> > > On Mon, 2020-07-20 at 11:14 +0200, Petr Vorel wrote:
> > > > Reasons to drop:
> > > > * outdated tests (from 2005)
> > > > * not used (NFS kernel maintainers use pynfs [1])
> > > > * written in Python (we support C and shell, see [2])
> > > > [1] http://git.linux-nfs.org/?p=bfields/pynfs.git;a=summary
> > > > [2] https://github.com/linux-test-project/ltp/issues/547
> > > Unlike pynfs, these tests run on a real NFS client, and were designed
> > > to test client implementations, as well as the servers.
> > > So if they get dropped from ltp, then we will have to figure out some
> > > other way of continuing to maintain them.
> > NFS tests using the kernel sound like a prime candidate for xfstests.
> In the past Yong Sun moved some ext4 related tests from LTP to xfstests.
> LTP has various NFS related tests. IMHO more important than where these tests
> should be is if anybody has a deeper look into them an cleanup them / rewrite
> them from scratch.
Although xfstests sounds like a natural choice, atm there are quite a lot NFS
tests in LTP. xfstests contain only single NFS test.
IMHO it's a choice of anybody who rewrites these tests whether he tries to put
them to LTP or into xfstests. If it were me I'd probably keep them in LTP,
because I prefer LTP framework capabilities.
Kind regards,
Petr
prev parent reply other threads:[~2020-07-21 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:14 [RFC PATCH 1/1] Remove nfsv4 Petr Vorel
2020-07-20 13:32 ` Trond Myklebust
2020-07-20 14:12 ` bfields
2020-07-20 14:36 ` Petr Vorel
2020-07-20 15:15 ` Petr Vorel
2020-07-20 17:01 ` bfields
2020-07-20 18:12 ` Petr Vorel
2020-07-20 15:17 ` Christoph Hellwig
2020-07-20 18:16 ` Petr Vorel
2020-07-21 9:31 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721093115.GB1164@dell5510 \
--to=pvorel@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=bfields@fieldses.org \
--cc=chrubis@suse.cz \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=trondmy@hammerspace.com \
--cc=yangx.jy@cn.fujitsu.com \
--cc=yosun@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).