From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@RedHat.com>
Cc: NeilBrown <neilb@suse.de>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/5 v2] nfs-utils: provide audit-logging of NFSv4 access
Date: Wed, 7 Apr 2021 15:55:33 -0400 [thread overview]
Message-ID: <20210407195533.GB3663@fieldses.org> (raw)
In-Reply-To: <f62bdd53-eb2c-604e-8168-3ef9e9076253@RedHat.com>
On Wed, Apr 07, 2021 at 03:33:41PM -0400, Steve Dickson wrote:
>
>
> On 4/7/21 3:14 PM, J. Bruce Fields wrote:
> > On Fri, Mar 19, 2021 at 05:09:22PM -0400, J. Bruce Fields wrote:
> >> On Sat, Mar 20, 2021 at 07:48:44AM +1100, NeilBrown wrote:
> >>> For NFSv4.1, only the EXCHANGE_ID is duplicate. There is only one
> >>> CREATE_SESSION, and that is where the client is confirmed. So only one
> >>> confirmed client.
> >>>
> >>> For NFSv4.0 bother SETCLIENTID and SETCLIENDID_CONFIRM are duplicate.
> >>> So maybe both clients get confirmed. I should check that.
> >>
> >> Drifting off topic, but I don't see how this client behavior makes
> >> sense. Mount is chatty enough without the unnecessary duplication.
> >> Looking at the code....
> >
> > I never sorted this out, by the way. I think there must be a bug,
> > though.
> My bad... I didn't realize you had concern with the patch...
> What needs to happen... to figure this out?
Sorry, it wasn't a concern with Neil's patches.
The thing I don't understand is why the client is sending these calls
twice. Anyway, that's more-or-less harmless behavior, and in kernel
code, nothing to do with nfs-utils.
--b.
prev parent reply other threads:[~2021-04-07 19:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 2:17 [PATCH 0/5 v2] nfs-utils: provide audit-logging of NFSv4 access NeilBrown
2021-03-01 2:17 ` [PATCH 4/5] mountd: add --cache-use-ipaddr option to force use_ipaddr NeilBrown
2021-03-01 2:17 ` [PATCH 2/5] mountd: Don't proactively add export info when fh info is requested NeilBrown
2021-03-01 2:17 ` [PATCH 1/5] mountd: reject unknown client IP when !use_ipaddr NeilBrown
2021-03-01 2:17 ` [PATCH 5/5] mountd: make default ttl settable by option NeilBrown
2021-03-01 2:17 ` [PATCH 3/5] mountd: add logging for authentication results for accesses NeilBrown
2021-03-01 3:43 ` [PATCH 0/5 v2] nfs-utils: provide audit-logging of NFSv4 access Yongcheng Yang
2021-03-02 2:26 ` NeilBrown
2021-03-01 18:50 ` J. Bruce Fields
2021-03-01 21:59 ` NeilBrown
2021-03-02 3:01 ` NeilBrown
2021-03-02 3:27 ` J. Bruce Fields
2021-03-02 3:49 ` NeilBrown
2021-03-02 4:05 ` J. Bruce Fields
2021-03-19 3:36 ` NeilBrown
2021-03-19 3:37 ` [PATCH] nfsd: report client confirmation status in "info" file NeilBrown
2021-03-19 3:38 ` [PATCH] mountd/exportd: only log confirmed clients, and poll for updates NeilBrown
2021-03-19 14:15 ` J. Bruce Fields
2021-03-19 20:43 ` NeilBrown
2021-03-19 22:39 ` [PATCH v2] " NeilBrown
2021-03-22 14:30 ` Chuck Lever III
2021-04-07 18:26 ` Steve Dickson
2021-03-19 22:38 ` [PATCH v2] nfsd: report client confirmation status in "info" file NeilBrown
2022-05-18 14:45 ` Chuck Lever III
2022-05-18 15:26 ` Chuck Lever III
2021-03-19 13:28 ` [PATCH 0/5 v2] nfs-utils: provide audit-logging of NFSv4 access J. Bruce Fields
2021-03-19 20:48 ` NeilBrown
2021-03-19 21:09 ` J. Bruce Fields
2021-03-22 17:06 ` J. Bruce Fields
2021-04-07 19:14 ` J. Bruce Fields
2021-04-07 19:33 ` Steve Dickson
2021-04-07 19:55 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407195533.GB3663@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@RedHat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).