linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>,
	trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: kbuild-all@lists.01.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 09/13] sunrpc: add a symlink from rpc-client directory to the xprt_switch
Date: Thu, 15 Apr 2021 12:56:07 +0800	[thread overview]
Message-ID: <202104151246.TcbgKc6J-lkp@intel.com> (raw)
In-Reply-To: <20210415022802.31692-10-olga.kornievskaia@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2706 bytes --]

Hi Olga,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on nfsd/nfsd-next v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a05b7df960093f762cbe85580d90bd3d0b83d54b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
        git checkout a05b7df960093f762cbe85580d90bd3d0b83d54b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/sunrpc/sysfs.c: In function 'rpc_sysfs_client_setup':
>> net/sunrpc/sysfs.c:164:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     164 |   int ret;
         |       ^~~


vim +/ret +164 net/sunrpc/sysfs.c

   151	
   152	void rpc_sysfs_client_setup(struct rpc_clnt *clnt,
   153				    struct rpc_xprt_switch *xprt_switch,
   154				    struct net *net)
   155	{
   156		struct rpc_sysfs_client *rpc_client;
   157	
   158		rpc_client = rpc_sysfs_client_alloc(rpc_sunrpc_client_kobj,
   159						    net, clnt->cl_clid);
   160		if (rpc_client) {
   161			char name[23];
   162			struct rpc_sysfs_xprt_switch *xswitch =
   163				(struct rpc_sysfs_xprt_switch *)xprt_switch->xps_sysfs;
 > 164			int ret;
   165	
   166			clnt->cl_sysfs = rpc_client;
   167			rpc_client->clnt = clnt;
   168			rpc_client->xprt_switch = xprt_switch;
   169			kobject_uevent(&rpc_client->kobject, KOBJ_ADD);
   170			snprintf(name, sizeof(name), "switch-%d", xprt_switch->xps_id);
   171			ret = sysfs_create_link_nowarn(&rpc_client->kobject,
   172						       &xswitch->kobject, name);
   173		}
   174	}
   175	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67309 bytes --]

  reply	other threads:[~2021-04-15  4:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  2:27 [PATCH 00/13] create sysfs files for changing IP address Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 01/13] sunrpc: Create a sunrpc directory under /sys/kernel/ Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 02/13] sunrpc: Create a client/ subdirectory in the sunrpc sysfs Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 03/13] sunrpc: Create per-rpc_clnt sysfs kobjects Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 04/13] sunrpc: Prepare xs_connect() for taking NULL tasks Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 05/13] sunrpc: add xprt id Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 06/13] sunrpc: add IDs to multipath Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 07/13] sunrpc: keep track of the xprt_class in rpc_xprt structure Olga Kornievskaia
2021-04-15  6:34   ` kernel test robot
2021-04-16  0:42   ` kernel test robot
2021-04-15  2:27 ` [PATCH 08/13] sunrpc: add xprt_switch direcotry to sunrpc's sysfs Olga Kornievskaia
2021-04-15  2:27 ` [PATCH 09/13] sunrpc: add a symlink from rpc-client directory to the xprt_switch Olga Kornievskaia
2021-04-15  4:56   ` kernel test robot [this message]
2021-04-15  2:27 ` [PATCH 10/13] sunrpc: add add sysfs directory per xprt under each xprt_switch Olga Kornievskaia
2021-04-15  2:28 ` [PATCH 11/13] sunrpc: add dst_attr attributes to the sysfs xprt directory Olga Kornievskaia
2021-04-15  4:31   ` kernel test robot
2021-04-15  2:28 ` [PATCH 12/13] sunrpc: provide transport info in the sysfs directory Olga Kornievskaia
2021-04-15  2:28 ` [PATCH 13/13] sunrpc: provide multipath " Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104151246.TcbgKc6J-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=anna.schumaker@netapp.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=olga.kornievskaia@gmail.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).