From: Bruce Fields <bfields@fieldses.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Chuck Lever III <chuck.lever@oracle.com>,
Neil Brown <neilb@suse.de>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Mel Gorman <mgorman@suse.com>, Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] SUNRPC: use congestion_wait() in svc_alloc_args()
Date: Mon, 6 Sep 2021 18:13:20 -0400 [thread overview]
Message-ID: <20210906221320.GA21567@fieldses.org> (raw)
In-Reply-To: <YTZ4E0Zh6F/WSpy0@casper.infradead.org>
On Mon, Sep 06, 2021 at 09:20:35PM +0100, Matthew Wilcox wrote:
> On Mon, Sep 06, 2021 at 03:46:34PM +0000, Chuck Lever III wrote:
> > Hi Neil-
> >
> > > On Sep 6, 2021, at 12:44 AM, NeilBrown <neilb@suse.de> wrote:
> > >
> > >
> > > Many places that need to wait before retrying a memory allocation use
> > > congestion_wait(). xfs_buf_alloc_pages() is a good example which
> > > follows a similar pattern to that in svc_alloc_args().
> > >
> > > It make sense to do the same thing in svc_alloc_args(); This will allow
> > > the allocation to be retried sooner if some backing device becomes
> > > non-congested before the timeout.
>
> It's adorable that you believe this is still true.
>
> https://lore.kernel.org/linux-mm/20191231125908.GD6788@bombadil.infradead.org/
So, what's the advice for now? Do we add the congestion_wait() call
anyway and assume it'll be fixed to do something less broken in the
future, or just skip it completely?
--b.
next prev parent reply other threads:[~2021-09-06 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 4:44 [PATCH] SUNRPC: use congestion_wait() in svc_alloc_args() NeilBrown
2021-09-06 15:46 ` Chuck Lever III
2021-09-06 20:20 ` Matthew Wilcox
2021-09-06 22:13 ` Bruce Fields [this message]
2021-09-06 22:22 ` NeilBrown
2021-09-07 0:41 ` NeilBrown
2021-09-07 14:53 ` Chuck Lever III
2021-09-07 15:39 ` Bruce Fields
2021-09-07 15:41 ` Mel Gorman
2021-09-07 16:21 ` Chuck Lever III
2021-09-07 21:47 ` NeilBrown
2021-09-07 8:17 ` Mel Gorman
2021-09-06 21:52 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906221320.GA21567@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mgorman@suse.com \
--cc=neilb@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).