From: Greg KH <greg@kroah.com>
To: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
linux-nfs@vger.kernel.org, Jacek Tomaka <Jacek.Tomaka@poczta.fm>
Subject: Re: [PATCH stable 6.1] NFS: Fix data corruption caused by congestion.
Date: Mon, 4 Mar 2024 12:31:45 +0100 [thread overview]
Message-ID: <2024030439-exclusion-tanning-b1d9@gregkh> (raw)
In-Reply-To: <170907634991.24797.14120500624611379941@noble.neil.brown.name>
On Wed, Feb 28, 2024 at 10:25:49AM +1100, NeilBrown wrote:
>
> when AOP_WRITEPAGE_ACTIVATE is returned (as NFS does when it detects
> congestion) it is important that the page is redirtied.
> nfs_writepage_locked() doesn't do this, so files can become corrupted as
> writes can be lost.
>
> Note that this is not needed in v6.8 as AOP_WRITEPAGE_ACTIVATE cannot be
> returned. It is needed for kernels v5.18..v6.7. From 6.3 onward the patch
> is different as it needs to mention "folio", not "page".
>
> Reported-and-tested-by: Jacek Tomaka <Jacek.Tomaka@poczta.fm>
> Fixes: 6df25e58532b ("nfs: remove reliance on bdi congestion")
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> fs/nfs/write.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-03-04 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 23:25 [PATCH stable 6.1] NFS: Fix data corruption caused by congestion NeilBrown
2024-03-04 11:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030439-exclusion-tanning-b1d9@gregkh \
--to=greg@kroah.com \
--cc=Jacek.Tomaka@poczta.fm \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).