From: Trond Myklebust <trondmy@hammerspace.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"bfields@redhat.com" <bfields@redhat.com>
Subject: Re: [PATCH RESEND 1/6] nfsd: fix filecache lookup
Date: Tue, 21 Jan 2020 23:07:12 +0000 [thread overview]
Message-ID: <20e074d92f514810b0268ea7b76f82b430ae80cf.camel@hammerspace.com> (raw)
In-Reply-To: <20200121212838.GC26055@fieldses.org>
On Tue, 2020-01-21 at 16:28 -0500, J. Bruce Fields wrote:
> On Mon, Jan 06, 2020 at 01:18:03PM -0500, Trond Myklebust wrote:
> > If the lookup keeps finding a nfsd_file with an unhashed open file,
> > then retry once only.
>
> So, symptoms are a hang?
>
> Should this be cc: stable, Fixes: 65294c1f2c5e ("nfsd: add a new
> struct
> file caching facility to nfsd") ?
I would recommend that we make it a stable fix, yes. We've hit it
internally, and I believe Chuck was hitting it as well.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2020-01-21 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 18:18 [PATCH RESEND 0/6] Improve performance of containerised knfsd Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 1/6] nfsd: fix filecache lookup Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 2/6] nfsd: cleanup nfsd_file_lru_dispose() Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 3/6] nfsd: Containerise filecache laundrette Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 4/6] nfsd: Remove unused constant NFSD_FILE_LRU_RESCAN Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 5/6] nfsd: Schedule the laundrette regularly irrespective of file errors Trond Myklebust
2020-01-06 18:18 ` [PATCH RESEND 6/6] nfsd: Reduce the number of calls to nfsd_file_gc() Trond Myklebust
2020-01-21 21:28 ` [PATCH RESEND 1/6] nfsd: fix filecache lookup J. Bruce Fields
2020-01-21 23:07 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e074d92f514810b0268ea7b76f82b430ae80cf.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).