From: David Howells <dhowells@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: dhowells@redhat.com, CIFS <linux-cifs@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Bruce Fields <bfields@fieldses.org>,
linux-crypto@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-afs@lists.infradead.org
Subject: Re: [RFC][PATCH 00/18] crypto: Add generic Kerberos library
Date: Thu, 12 Nov 2020 16:54:06 +0000 [thread overview]
Message-ID: <2422487.1605200046@warthog.procyon.org.uk> (raw)
In-Reply-To: <22138FE2-9E79-4E24-99FC-74A35651B0C1@oracle.com>
Chuck Lever <chuck.lever@oracle.com> wrote:
> Really? My understanding of the Linux kernel SUNRPC implementation is
> that it uses asynchronous, even for small data items. Maybe I'm using
> the terminology incorrectly.
Seems to be synchronous, at least in its use of skcipher:
grep -e skcipher *
gss_krb5_crypto.c:#include <crypto/skcipher.h>
gss_krb5_crypto.c: struct crypto_sync_skcipher *tfm,
gss_krb5_crypto.c: if (length % crypto_sync_skcipher_blocksize(tfm) != 0)
gss_krb5_crypto.c: if (crypto_sync_skcipher_ivsize(tfm) > GSS_KRB5_MAX_BLOCKSIZE) {
gss_krb5_crypto.c: crypto_sync_skcipher_ivsize(tfm));
gss_krb5_crypto.c: memcpy(local_iv, iv, crypto_sync_skcipher_ivsize(tfm));
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, tfm);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_set_crypt(req, sg, sg, length, local_iv);
gss_krb5_crypto.c: ret = crypto_skcipher_encrypt(req);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c: struct crypto_sync_skcipher *tfm,
gss_krb5_crypto.c: if (length % crypto_sync_skcipher_blocksize(tfm) != 0)
gss_krb5_crypto.c: if (crypto_sync_skcipher_ivsize(tfm) > GSS_KRB5_MAX_BLOCKSIZE) {
gss_krb5_crypto.c: crypto_sync_skcipher_ivsize(tfm));
gss_krb5_crypto.c: memcpy(local_iv, iv, crypto_sync_skcipher_ivsize(tfm));
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, tfm);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_set_crypt(req, sg, sg, length, local_iv);
gss_krb5_crypto.c: ret = crypto_skcipher_decrypt(req);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c: struct skcipher_request *req;
gss_krb5_crypto.c: struct crypto_sync_skcipher *tfm =
gss_krb5_crypto.c: crypto_sync_skcipher_reqtfm(desc->req);
gss_krb5_crypto.c: fraglen = thislen & (crypto_sync_skcipher_blocksize(tfm) - 1);
gss_krb5_crypto.c: skcipher_request_set_crypt(desc->req, desc->infrags, desc->outfrags,
gss_krb5_crypto.c: ret = crypto_skcipher_encrypt(desc->req);
gss_krb5_crypto.c:gss_encrypt_xdr_buf(struct crypto_sync_skcipher *tfm, struct xdr_buf *buf,
gss_krb5_crypto.c: BUG_ON((buf->len - offset) % crypto_sync_skcipher_blocksize(tfm) != 0);
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, tfm);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c: struct skcipher_request *req;
gss_krb5_crypto.c: struct crypto_sync_skcipher *tfm =
gss_krb5_crypto.c: crypto_sync_skcipher_reqtfm(desc->req);
gss_krb5_crypto.c: fraglen = thislen & (crypto_sync_skcipher_blocksize(tfm) - 1);
gss_krb5_crypto.c: skcipher_request_set_crypt(desc->req, desc->frags, desc->frags,
gss_krb5_crypto.c: ret = crypto_skcipher_decrypt(desc->req);
gss_krb5_crypto.c:gss_decrypt_xdr_buf(struct crypto_sync_skcipher *tfm, struct xdr_buf *buf,
gss_krb5_crypto.c: BUG_ON((buf->len - offset) % crypto_sync_skcipher_blocksize(tfm) != 0);
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, tfm);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c:gss_krb5_cts_crypt(struct crypto_sync_skcipher *cipher, struct xdr_buf *buf,
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, cipher);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_set_crypt(req, sg, sg, len, iv);
gss_krb5_crypto.c: ret = crypto_skcipher_encrypt(req);
gss_krb5_crypto.c: ret = crypto_skcipher_decrypt(req);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c: struct crypto_sync_skcipher *cipher, *aux_cipher;
gss_krb5_crypto.c: blocksize = crypto_sync_skcipher_blocksize(cipher);
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, aux_cipher);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_crypto.c: struct crypto_sync_skcipher *cipher, *aux_cipher;
gss_krb5_crypto.c: blocksize = crypto_sync_skcipher_blocksize(cipher);
gss_krb5_crypto.c: skcipher_request_set_sync_tfm(req, aux_cipher);
gss_krb5_crypto.c: skcipher_request_set_callback(req, 0, NULL, NULL);
gss_krb5_crypto.c: skcipher_request_zero(req);
gss_krb5_keys.c:#include <crypto/skcipher.h>
gss_krb5_keys.c: struct crypto_sync_skcipher *cipher;
gss_krb5_keys.c: cipher = crypto_alloc_sync_skcipher(gk5e->encrypt_name, 0, 0);
gss_krb5_keys.c: if (crypto_sync_skcipher_setkey(cipher, inkey->data, inkey->len))
gss_krb5_keys.c: crypto_free_sync_skcipher(cipher);
gss_krb5_mech.c:#include <crypto/skcipher.h>
gss_krb5_mech.c: struct krb5_ctx *ctx, struct crypto_sync_skcipher **res)
gss_krb5_mech.c: *res = crypto_alloc_sync_skcipher(ctx->gk5e->encrypt_name, 0, 0);
gss_krb5_mech.c: if (crypto_sync_skcipher_setkey(*res, key.data, key.len)) {
gss_krb5_mech.c: crypto_free_sync_skcipher(*res);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->seq);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->enc);
gss_krb5_mech.c:static struct crypto_sync_skcipher *
gss_krb5_mech.c: struct crypto_sync_skcipher *cp;
gss_krb5_mech.c: cp = crypto_alloc_sync_skcipher(cname, 0, 0);
gss_krb5_mech.c: if (crypto_sync_skcipher_setkey(cp, key, ctx->gk5e->keylength)) {
gss_krb5_mech.c: crypto_free_sync_skcipher(cp);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->seq);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->initiator_enc_aux);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->acceptor_enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(ctx->initiator_enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->seq);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->acceptor_enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->initiator_enc);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->acceptor_enc_aux);
gss_krb5_mech.c: crypto_free_sync_skcipher(kctx->initiator_enc_aux);
gss_krb5_seqnum.c:#include <crypto/skcipher.h>
gss_krb5_seqnum.c: struct crypto_sync_skcipher *key,
gss_krb5_seqnum.c: struct crypto_sync_skcipher *key = kctx->seq;
gss_krb5_wrap.c:#include <crypto/skcipher.h>
gss_krb5_wrap.c: blocksize = crypto_sync_skcipher_blocksize(kctx->enc);
gss_krb5_wrap.c: blocksize = crypto_sync_skcipher_blocksize(kctx->enc);
David
next prev parent reply other threads:[~2020-11-12 16:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 12:57 [RFC][PATCH 00/18] crypto: Add generic Kerberos library David Howells
2020-11-12 12:57 ` [PATCH 01/18] crypto/krb5: Implement Kerberos crypto core David Howells
2020-11-12 12:58 ` [PATCH 02/18] crypto/krb5: Add some constants out of sunrpc headers David Howells
2020-11-12 12:58 ` [PATCH 03/18] crypto/krb5: Provide infrastructure and key derivation David Howells
2020-11-12 12:58 ` [PATCH 04/18] crypto/krb5: Implement the Kerberos5 rfc3961 " David Howells
2020-11-12 12:58 ` [PATCH 05/18] crypto/krb5: Implement the Kerberos5 rfc3961 encrypt and decrypt functions David Howells
2020-11-12 12:58 ` [PATCH 06/18] crypto/krb5: Implement the Kerberos5 rfc3961 get_mic and verify_mic David Howells
2020-11-12 12:58 ` [PATCH 07/18] crypto/krb5: Implement the AES enctypes from rfc3962 David Howells
2020-11-12 12:58 ` [PATCH 08/18] crypto/krb5: Implement crypto self-testing David Howells
2020-11-12 12:58 ` [PATCH 09/18] crypto/krb5: Implement the AES enctypes from rfc8009 David Howells
2020-11-12 12:59 ` [PATCH 10/18] crypto/krb5: Implement the AES encrypt/decrypt " David Howells
2020-11-12 12:59 ` [PATCH 11/18] crypto/krb5: Add the AES self-testing data " David Howells
2020-11-12 12:59 ` [PATCH 12/18] crypto/krb5: Implement the Camellia enctypes from rfc6803 David Howells
2020-11-12 12:59 ` [PATCH 13/18] rxrpc: Add the security index for yfs-rxgk David Howells
2020-11-12 12:59 ` [PATCH 14/18] rxrpc: Add YFS RxGK (GSSAPI) security class David Howells
2020-11-12 12:59 ` [PATCH 15/18] rxrpc: rxgk: Provide infrastructure and key derivation David Howells
2020-11-12 12:59 ` [PATCH 16/18] rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI) David Howells
2020-11-12 13:00 ` [PATCH 17/18] rxrpc: rxgk: Implement connection rekeying David Howells
2020-11-12 13:00 ` [PATCH 18/18] rxgk: Support OpenAFS's rxgk implementation David Howells
2020-11-12 13:44 ` [RFC][PATCH 00/18] crypto: Add generic Kerberos library David Howells
2020-11-12 14:36 ` Chuck Lever
2020-11-12 15:42 ` David Howells
2020-11-12 15:49 ` Chuck Lever
2020-11-12 16:54 ` David Howells [this message]
2020-11-12 21:07 ` Bruce Fields
2020-11-12 21:09 ` Chuck Lever
2020-11-12 18:37 ` J. Bruce Fields
2020-11-12 18:39 ` Chuck Lever
2020-11-26 6:33 ` Herbert Xu
2020-11-26 8:19 ` David Howells
2020-11-27 5:07 ` Herbert Xu
2020-12-01 8:44 ` David Howells
2020-12-01 8:46 ` Herbert Xu
2020-12-01 9:12 ` David Howells
2020-12-01 10:36 ` Herbert Xu
2020-12-04 14:59 ` Why the auxiliary cipher in gss_krb5_crypto.c? David Howells
2020-12-04 15:46 ` Bruce Fields
2020-12-04 16:05 ` Chuck Lever
2020-12-04 16:14 ` Bruce Fields
2020-12-04 16:01 ` David Howells
2020-12-04 16:03 ` Bruce Fields
2020-12-04 16:50 ` David Howells
2020-12-04 17:06 ` Ard Biesheuvel
2020-12-04 17:19 ` David Howells
2020-12-04 17:35 ` Ard Biesheuvel
2020-12-04 21:08 ` Herbert Xu
2020-12-07 8:24 ` David Howells
2020-12-07 12:01 ` David Howells
2020-12-07 13:08 ` Ard Biesheuvel
2020-12-07 14:15 ` David Howells
2020-12-08 8:27 ` Ard Biesheuvel
2020-12-08 9:18 ` David Howells
2020-12-04 18:13 ` Theodore Y. Ts'o
2020-12-08 13:25 ` David Howells
2020-12-08 14:04 ` Ard Biesheuvel
2020-12-08 14:13 ` David Howells
2020-12-08 14:02 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2422487.1605200046@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).