Re: [PATCH v1 00/22] SUNRPC: Replace dprintk calls with tracepoints

[Chuck Lever <chuck.lever@oracle.com>]

> On Jul 8, 2020, at 4:08 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> Hi-
> 
> This series replaces many client-side RPC dprintk call sites with
> tracepoints. The goals of this series are:
> 
> - Replace chatty dprintk call sites with tracepoints, which can
>  handle a higher event rate, and won't get rate-limited.
> 
> - At some later point, expand the 0-64K range of RPC task IDs.
>  Task IDs would be displayed only by tracepoints as 32-bit unsigned
>  integers.
> 
> - Eliminate redundant tracepoints in the transport implementations.

None of the patches in this series made it into v5.9. I don't recall
seeing any feedback on these either. Can they be considered for v5.10?


> ---
> 
> Chuck Lever (22):
>      SUNRPC: Remove trace_xprt_complete_rqst()
>      SUNRPC: Hoist trace_xprtrdma_op_allocate into generic code
>      SUNRPC: Remove debugging instrumentation from xprt_release
>      SUNRPC: Update debugging instrumentation in xprt_do_reserve()
>      SUNRPC: Replace dprintk() call site in xprt_prepare_transmit
>      SUNRPC: Replace dprintk() call site in xs_nospace()
>      SUNRPC: Remove the dprint_status() macro
>      SUNRPC: Remove dprintk call site in call_start()
>      SUNRPC: Replace connect dprintk call sites with a tracepoint
>      SUNRPC: Mitigate cond_resched() in xprt_transmit()
>      SUNRPC: Add trace_rpc_timeout_status()
>      SUNRPC: Trace call_refresh events
>      SUNRPC: Remove dprintk call site in call_decode
>      SUNRPC: Clean up call_bind_status() observability
>      SUNRPC: Remove rpcb_getport_async dprintk call sites
>      SUNRPC: Hoist trace_xprtrdma_op_setport into generic code
>      SUNRPC: Remove dprintk call sites in rpcbind XDR functions
>      SUNRPC: Remove more dprintks in rpcb_clnt.c
>      SUNRPC: Replace rpcbind dprintk call sites with tracepoints
>      SUNRPC: Clean up RPC scheduler tracepoints
>      SUNRPC: Remove dprintk call sites in RPC queuing functions
>      SUNRPC: Remove remaining dprintks from sched.c
> 
> 
> include/trace/events/rpcrdma.h  |  63 -------
> include/trace/events/sunrpc.h   | 285 ++++++++++++++++++++++++++++----
> net/sunrpc/clnt.c               |  75 ++-------
> net/sunrpc/rpcb_clnt.c          | 129 +++------------
> net/sunrpc/sched.c              |  52 +-----
> net/sunrpc/xprt.c               |  22 +--
> net/sunrpc/xprtrdma/transport.c |   7 -
> net/sunrpc/xprtsock.c           |   5 +-
> 8 files changed, 304 insertions(+), 334 deletions(-)
> 
> --
> Chuck Lever

--
Chuck Lever