* [PATCH v3] NFSv4: try lease recovery on NFS4ERR_EXPIRED
@ 2020-01-28 8:37 Robert Milkowski
2020-01-28 15:44 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Robert Milkowski @ 2020-01-28 8:37 UTC (permalink / raw)
To: linux-nfs, 'Trond Myklebust'
Cc: 'Anna Schumaker', 'Chuck Lever', linux-kernel
From: Robert Milkowski <rmilkowski@gmail.com>
Currently, if an nfs server returns NFS4ERR_EXPIRED to open(),
we return EIO to applications without even trying to recover.
Fixes: 272289a3df72 ("NFSv4: nfs4_do_handle_exception() handle revoke/expiry of a single stateid")
Signed-off-by: Robert Milkowski <rmilkowski@gmail.com>
---
fs/nfs/nfs4proc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 76d3716..b7c4044 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3187,6 +3187,11 @@ static struct nfs4_state *nfs4_do_open(struct inode *dir,
exception.retry = 1;
continue;
}
+ if (status == -NFS4ERR_EXPIRED) {
+ nfs4_schedule_lease_recovery(server->nfs_client);
+ exception.retry = 1;
+ continue;
+ }
if (status == -EAGAIN) {
/* We must have found a delegation */
exception.retry = 1;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] NFSv4: try lease recovery on NFS4ERR_EXPIRED
2020-01-28 8:37 [PATCH v3] NFSv4: try lease recovery on NFS4ERR_EXPIRED Robert Milkowski
@ 2020-01-28 15:44 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2020-01-28 15:44 UTC (permalink / raw)
To: linux-nfs, rmilkowski; +Cc: anna.schumaker, linux-kernel, chuck.lever
On Tue, 2020-01-28 at 08:37 +0000, Robert Milkowski wrote:
> From: Robert Milkowski <rmilkowski@gmail.com>
>
> Currently, if an nfs server returns NFS4ERR_EXPIRED to open(),
> we return EIO to applications without even trying to recover.
>
> Fixes: 272289a3df72 ("NFSv4: nfs4_do_handle_exception() handle
> revoke/expiry of a single stateid")
> Signed-off-by: Robert Milkowski <rmilkowski@gmail.com>
> ---
> fs/nfs/nfs4proc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 76d3716..b7c4044 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3187,6 +3187,11 @@ static struct nfs4_state *nfs4_do_open(struct
> inode *dir,
> exception.retry = 1;
> continue;
> }
> + if (status == -NFS4ERR_EXPIRED) {
> + nfs4_schedule_lease_recovery(server-
> >nfs_client);
> + exception.retry = 1;
> + continue;
> + }
> if (status == -EAGAIN) {
> /* We must have found a delegation */
> exception.retry = 1;
Looks good.
Reviewed-by: Trond Myklebust <trond.myklebust@hammerspace.com>
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-28 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 8:37 [PATCH v3] NFSv4: try lease recovery on NFS4ERR_EXPIRED Robert Milkowski
2020-01-28 15:44 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).