From: Steve Dickson <SteveD@RedHat.com>
To: Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/4] idmapd: Add graceful exit and resource cleanup
Date: Thu, 23 Jul 2020 15:16:12 -0400 [thread overview]
Message-ID: <36cad163-448e-9018-78e8-fadb320de8a4@RedHat.com> (raw)
In-Reply-To: <5170afa5-9751-0ab6-5e93-f103857ee259@nazar.ca>
On 7/23/20 2:25 PM, Doug Nazar wrote:
> On 2020-07-23 13:56, Steve Dickson wrote:
>> @@ -290,6 +306,9 @@ main(int argc, char **argv)
>>> serverstart = 0;
>>> }
>>> + /* Not needed anymore */
>>> + conf_cleanup();
>>> +
>> I'm a bit confused by this comment... If it is not needed why as the call added?
>
> Sorry, I should have been a bit more verbose in the comment. I meant that we didn't need access to the config file anymore (we've already looked up everything) and can free those resources early.
>
> Perhaps /* Config not needed anymore */ or something.
Ok.. got it... I'll make it work...
steved.
>
> Doug
>
next prev parent reply other threads:[~2020-07-23 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 5:53 [PATCH 0/4] nfs-utils patches Doug Nazar
2020-07-22 5:53 ` [PATCH 1/4] exportfs: Fix a few valgrind warnings Doug Nazar
2020-07-22 5:53 ` [PATCH 2/4] idmapd: Add graceful exit and resource cleanup Doug Nazar
2020-07-23 17:56 ` Steve Dickson
2020-07-23 18:25 ` Doug Nazar
2020-07-23 19:16 ` Steve Dickson [this message]
2020-07-22 5:53 ` [PATCH 3/4] idmapd: Fix client mode support Doug Nazar
2020-07-22 5:53 ` [PATCH 4/4] nfsidmap: Allow overriding location of method libraries Doug Nazar
2020-07-27 14:42 ` [PATCH 0/4] nfs-utils patches Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36cad163-448e-9018-78e8-fadb320de8a4@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nazard@nazar.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).