From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: fix_priv_head
Date: Thu, 23 Jul 2020 13:46:19 -0400 [thread overview]
Message-ID: <3799C9E0-DFF3-450C-A815-14BAFAC97EA8@oracle.com> (raw)
Hi Bruce-
I'm trying to figure out if fix_priv_head is still necessary. This
was introduced by 7c9fdcfb1b64 ("[PATCH] knfsd: svcrpc: gss:
server-side implementation of rpcsec_gss privacy").
static void
fix_priv_head(struct xdr_buf *buf, int pad)
{
if (buf->page_len == 0) {
/* We need to adjust head and buf->len in tandem in this
* case to make svc_defer() work--it finds the original
* buffer start using buf->len - buf->head[0].iov_len. */
buf->head[0].iov_len -= pad;
}
}
It doesn't seem like unwrapping can ever result in a buffer length that
is not quad-aligned. Is that simply a characteristic of modern enctypes?
--
Chuck Lever
next reply other threads:[~2020-07-23 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 17:46 Chuck Lever [this message]
2020-07-23 19:38 ` fix_priv_head Bruce Fields
2020-07-23 20:23 ` fix_priv_head Chuck Lever
2020-07-24 1:17 ` fix_priv_head Bruce Fields
2020-07-24 14:10 ` fix_priv_head Chuck Lever
2020-07-24 20:39 ` fix_priv_head Bruce Fields
2020-07-24 21:05 ` fix_priv_head Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3799C9E0-DFF3-450C-A815-14BAFAC97EA8@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).