From: "Benjamin Coddington" <bcodding@redhat.com>
To: "kbuild test robot" <lkp@intel.com>
Cc: kbuild-all@01.org, trond.myklebust@hammerspace.com,
anna.schumaker@netapp.com, rjw@rjwysocki.net, pavel@ucw.cz,
len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] freezer,NFS: add an unsafe schedule_timeout_interruptable freezable helper for NFS
Date: Thu, 29 Aug 2019 11:30:59 -0400 [thread overview]
Message-ID: <3BADDECB-E1BB-4970-89C1-11AE4A27EF19@redhat.com> (raw)
In-Reply-To: <201908291805.HOQuJYMY%lkp@intel.com>
Thanks robot!
I'll send a v2 that works with !CONFIG_FREEZER.
Ben
On 29 Aug 2019, at 7:02, kbuild test robot wrote:
> Hi Benjamin,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.3-rc6 next-20190828]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Benjamin-Coddington/freezer-NFS-add-an-unsafe-schedule_timeout_interruptable-freezable-helper-for-NFS/20190829-161623
> config: x86_64-randconfig-f004-201934 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> fs/nfs/nfs4proc.c: In function 'nfs4_delay_interruptible':
>>> fs/nfs/nfs4proc.c:418:2: error: implicit declaration of function
>>> 'freezable_schedule_timeout_interruptible_unsafe'; did you mean
>>> 'freezable_schedule_timeout_interruptible'?
>>> [-Werror=implicit-function-declaration]
> freezable_schedule_timeout_interruptible_unsafe(nfs4_update_delay(timeout));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> freezable_schedule_timeout_interruptible
> cc1: some warnings being treated as errors
>
> vim +418 fs/nfs/nfs4proc.c
>
> 413
> 414 static int nfs4_delay_interruptible(long *timeout)
> 415 {
> 416 might_sleep();
> 417
>> 418 freezable_schedule_timeout_interruptible_unsafe(nfs4_update_delay(timeout));
> 419 if (!signal_pending(current))
> 420 return 0;
> 421 return __fatal_signal_pending(current) ? -EINTR :-ERESTARTSYS;
> 422 }
> 423
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
next prev parent reply other threads:[~2019-08-29 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:52 [PATCH] freezer,NFS: add an unsafe schedule_timeout_interruptable freezable helper for NFS Benjamin Coddington
2019-08-29 11:02 ` kbuild test robot
2019-08-29 15:30 ` Benjamin Coddington [this message]
2019-08-29 20:23 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BADDECB-E1BB-4970-89C1-11AE4A27EF19@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=kbuild-all@01.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).