From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@hammerspace.com>
Cc: anna.schumaker@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Always return the error that truncates a flushing page
Date: Mon, 28 Jan 2019 13:55:34 -0500 [thread overview]
Message-ID: <4512E750-0B6F-4842-B7B8-469FF04FBB00@redhat.com> (raw)
In-Reply-To: <9fc3d4ee7d8eafdfdb7b7c1397ecb25dd22e12b7.camel@hammerspace.com>
On 28 Jan 2019, at 12:59, Trond Myklebust wrote:
> Hi Ben
>
> We were apparently both looking at the same code last week ☺. I have a
> similar patch, but that also fixes a similar clobbering issue with the
> nfs_error_is_fatal() error just a few lines further down.
>
> Without the extra hunk, we could end up converting an interrupted call
> into a 'successful' write.
>
> Cheers
> Trond
Looks right to me. I hope you'll take the Fixes and stable version from
my patch, which will cover the problem I'm seeing.
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Ben
next prev parent reply other threads:[~2019-01-28 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 15:19 [PATCH] NFS: Always return the error that truncates a flushing page Benjamin Coddington
2019-01-28 17:59 ` Trond Myklebust
2019-01-28 18:55 ` Benjamin Coddington [this message]
2019-01-29 20:49 ` Trond Myklebust
2019-01-29 22:34 ` Benjamin Coddington
2019-01-30 9:03 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4512E750-0B6F-4842-B7B8-469FF04FBB00@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).