From: Trond Myklebust <trondmy@hammerspace.com>
To: "david@fromorbit.com" <david@fromorbit.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"bfields@redhat.com" <bfields@redhat.com>
Subject: Re: [PATCH] nfsd: Clone should commit src file metadata too
Date: Wed, 18 Dec 2019 20:01:29 +0000 [thread overview]
Message-ID: <48a93ddf23eb8d377509372775ff506d99f356db.camel@hammerspace.com> (raw)
In-Reply-To: <20191218194905.GW19213@dread.disaster.area>
On Thu, 2019-12-19 at 06:49 +1100, Dave Chinner wrote:
>
> IOWs, This would be much more efficient as:
>
> fsync(dst)
> commit_inode_metadata(src)
>
> as it would end up as:
>
> writeback data (dst data)
> journal write(src+dst metadata)
>
> and the call to commit_inode_metadata(src) ends up being a no-op
> with almost no overhead...
>
Thanks Dave! Fixed up in v2.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2019-12-18 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 17:37 [PATCH] nfsd: Clone should commit src file metadata too Trond Myklebust
2019-12-18 19:49 ` Dave Chinner
2019-12-18 20:01 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a93ddf23eb8d377509372775ff506d99f356db.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=bfields@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).