From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Steve Dickson <SteveD@RedHat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning
Date: Thu, 16 Jan 2020 21:38:45 +0100 [thread overview]
Message-ID: <4950679e-f8d0-c9ce-b08d-62801acd2c12@benettiengineering.com> (raw)
In-Reply-To: <a9f351c6-22e5-35ef-7119-d261ef8d0159@RedHat.com>
On 1/16/20 9:07 PM, Steve Dickson wrote:
>
>
> On 1/15/20 11:29 AM, Giulio Benetti wrote:
>> Hi Steve,
>>
>> you've missed this patch while applying the series. Can you please commit it?
> It is in...
>
> commit 6f4568f1f7395f967cc03995dcfb79a1ac5c11cd
> Author: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Date: Mon Jan 6 14:23:04 2020 -0500
>
> rpcgen: rpc_hout: fix potential -Wformat-security warning
>
> f_print()'s argument "separator" is not known because it's passed as an
> argument and with -Wformat-security will cause a useless warning. Let's
> ignore by adding "#pragma GCC diagnostic ignored/warning" before and
> after f_print().
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> what am I missing?
Ah you've merged them together, now I see:
[5/7] https://patchwork.kernel.org/patch/11317493/
[6/7] https://patchwork.kernel.org/patch/11317489/
I didn't notice it while pull rebasing from upstream, because I have
another patch similar to that after bumping to latest version of rpcgen.
Sorry for the noise and thank you!
Best regards
--
Giulio Benetti
Benetti Engineering sas
next prev parent reply other threads:[~2020-01-16 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 21:50 [nfs-utils PATCH 0/7] silence some warning in rpcgen Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 1/7] rpcgen: rpc_cout: silence unused def parameter Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 2/7] rpcgen: rpc_util: add storeval args to prototype Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 3/7] rpcgen: rpc_util: add findval " Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 4/7] rpcgen: rpc_parse: add get_definition() void argument Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning Giulio Benetti
2020-01-15 16:29 ` Giulio Benetti
2020-01-16 20:07 ` Steve Dickson
2020-01-16 20:38 ` Giulio Benetti [this message]
2020-01-03 21:50 ` [nfs-utils PATCH 6/7] rpcgen: rpc_hout: fix potential -Wformat-security warning Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 7/7] rpcgen: rpc_hout: fix indentation on f_print() argument separator Giulio Benetti
2020-01-07 19:06 ` [nfs-utils PATCH 0/7] silence some warning in rpcgen Steve Dickson
2020-01-09 14:00 ` Giulio Benetti
2020-01-09 15:10 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4950679e-f8d0-c9ce-b08d-62801acd2c12@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=SteveD@RedHat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).