From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@hammerspace.com>
Cc: linux-nfs@vger.kernel.org, anna.schumaker@netapp.com
Subject: Re: client skips revalidation if holding a delegation
Date: Tue, 11 Jun 2019 13:01:43 -0400 [thread overview]
Message-ID: <53641A5A-1888-4864-B48A-69D73DB000C0@redhat.com> (raw)
In-Reply-To: <2cc7cbfda42601d2e52ee63bed2dbb4140401adc.camel@hammerspace.com>
On 10 Jun 2019, at 12:43, Trond Myklebust wrote:
> On Mon, 2019-06-10 at 10:14 -0400, Benjamin Coddington wrote:
>> On 4 Jun 2019, at 15:00, Benjamin Coddington wrote:
>>
>>> At least now I can spend some time on it and not feel aimless,
>>> thanks for
>>> the closer look.
>>
>> I am not finding a reliable way to fix this and retain the
>> optimization. I
>> will send a patch to remove it.
>
>
> How about just moving the optimisation into the if
> (nfs_check_verifier()) { } case? There should be no need to do the
> nfs_lookup_verify_inode() dance if we hold a delegation. should there?
Ok, right -- we can optimize that away.. I'll see what sticks to the wall.
Ben
next prev parent reply other threads:[~2019-06-11 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 12:41 client skips revalidation if holding a delegation Benjamin Coddington
2019-06-04 12:56 ` Trond Myklebust
2019-06-04 14:10 ` Benjamin Coddington
2019-06-04 14:53 ` Trond Myklebust
2019-06-04 19:00 ` Benjamin Coddington
2019-06-10 14:14 ` Benjamin Coddington
2019-06-10 16:43 ` Trond Myklebust
2019-06-11 17:01 ` Benjamin Coddington [this message]
2019-06-10 17:08 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53641A5A-1888-4864-B48A-69D73DB000C0@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).