linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
@ 2019-01-31  0:46 Gustavo A. R. Silva
  2019-01-31 14:11 ` Chuck Lever
  0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-31  0:46 UTC (permalink / raw)
  To: Trond Myklebust, Anna Schumaker, J. Bruce Fields, Jeff Layton,
	David S. Miller
  Cc: linux-nfs, netdev, linux-kernel, Gustavo A. R. Silva

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 net/sunrpc/xprtrdma/verbs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 4994e75945b8..9e8cf7456840 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
 {
 	struct rpcrdma_sendctx *sc;
 
-	sc = kzalloc(sizeof(*sc) +
-		     ia->ri_max_send_sges * sizeof(struct ib_sge),
+	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
 		     GFP_KERNEL);
 	if (!sc)
 		return NULL;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-05-28 13:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31  0:46 [PATCH net-next] xprtrdma: Use struct_size() in kzalloc() Gustavo A. R. Silva
2019-01-31 14:11 ` Chuck Lever
2019-02-08  3:49   ` Gustavo A. R. Silva
2019-03-28 20:41   ` Gustavo A. R. Silva
2019-05-23 22:36     ` Gustavo A. R. Silva
2019-05-23 23:02       ` Chuck Lever
2019-05-23 23:32       ` David Miller
2019-05-23 23:43         ` Gustavo A. R. Silva
2019-05-28 13:56           ` Schumaker, Anna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).