linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	linux-nfs@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [nfs-utils PATCH] locktest: Makefile.am: remove host compiler costraint
Date: Wed, 22 Jan 2020 10:24:18 -0500	[thread overview]
Message-ID: <6606c604-61ef-a3fa-8ced-1d9dfb822f64@RedHat.com> (raw)
In-Reply-To: <20200119191047.GB11432@dell5510>

Petr,

On 1/19/20 2:10 PM, Petr Vorel wrote:
> Hi,
> 
>> Currently locktest can be built only for host because CC_FOR_BUILD is
>> specified as CC, but this leads to build failure when passing CFLAGS not
>> available on host gcc(i.e. -mlongcalls) and most of all locktest would
>> be available on target systems the same way as rpcgen etc. So remove CC
>> and LIBTOOL assignments.
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> Tested-by: Petr Vorel <petr.vorel@gmail.com>
> NOTE: as I understand it's a compilation issue of a tool, so I didn't run
> rpcgen, I just test various compilation variants for buildroot.
Just to be clear... Giulio's patch, removing CC and LIBTOOL from the
locktest/Makefile.am does allows your cross build to succeed, correct?

steved.

> 
> Kind regards,
> Petr
> 
>> ---
>>  tools/locktest/Makefile.am | 3 ---
>>  1 file changed, 3 deletions(-)
> 
>> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
>> index 3156815d..e8914655 100644
>> --- a/tools/locktest/Makefile.am
>> +++ b/tools/locktest/Makefile.am
>> @@ -1,8 +1,5 @@
>>  ## Process this file with automake to produce Makefile.in
> 
>> -CC=$(CC_FOR_BUILD)
>> -LIBTOOL = @LIBTOOL@ --tag=CC
>> -
>>  noinst_PROGRAMS = testlk
>>  testlk_SOURCES = testlk.c
>>  testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
> 


  reply	other threads:[~2020-01-22 15:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 16:08 [nfs-utils PATCH] locktest: Makefile.am: remove host compiler costraint Giulio Benetti
2020-01-19 19:10 ` Petr Vorel
2020-01-22 15:24   ` Steve Dickson [this message]
2020-01-22 16:13     ` Petr Vorel
2020-01-22 16:44       ` Steve Dickson
2020-01-22 17:56 ` Steve Dickson
2020-01-22 18:11   ` Giulio Benetti
2020-01-22 18:54     ` Giulio Benetti
2020-01-22 19:30       ` Steve Dickson
2020-01-22 21:55         ` Giulio Benetti
2020-01-27 18:41           ` Steve Dickson
2020-01-27 18:58             ` Giulio Benetti
2020-01-27 19:03               ` Steve Dickson
2020-01-27 19:51                 ` Giulio Benetti
2020-02-07 12:33                   ` Giulio Benetti
2020-02-07 15:45                     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6606c604-61ef-a3fa-8ced-1d9dfb822f64@RedHat.com \
    --to=steved@redhat.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=petr.vorel@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).