linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "smayhew@redhat.com" <smayhew@redhat.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	"dwysocha@redhat.com" <dwysocha@redhat.com>
Subject: Re: [PATCH v2 1/3] SUNRPC: Fix disconnection races
Date: Tue, 18 Dec 2018 12:27:53 -0500	[thread overview]
Message-ID: <68DFAB69-180B-4B78-B4F3-EB7DD7B8152C@oracle.com> (raw)
In-Reply-To: <b4b3eeb9ed30437998c9cc7766012ff0fd316b8e.camel@hammerspace.com>



> On Dec 18, 2018, at 11:02 AM, Trond Myklebust <trondmy@hammerspace.com> wrote:
> 
> On Tue, 2018-12-18 at 10:59 -0500, Chuck Lever wrote:
>>> On Dec 18, 2018, at 10:55 AM, Trond Myklebust <
>>> trondmy@hammerspace.com> wrote:
>>> 
>>> On Tue, 2018-12-18 at 09:20 -0500, Scott Mayhew wrote:
>>>> I ran Dave's test in a loop over night with these 3 patches on
>>>> top of
>>>> v4.20-rc7 and didn't see any more of the XPRT_WRITE_SPACE hangs.
>>>> 
>>> 
>>> Thanks for verifying that!
>> 
>> With these three patches and my RDMA-related disconnect fixes, fio8
>> on krb5i
>> now works fine, even though the connect count was 508. No stalls or
>> deadlocks.
>> 
>> Tested-by: Chuck Lever <chuck.lever@oracle.com>
> 
> Yay! Thanks Chuck.

I am highly in favor of fewer thundering herd wake-ups !  ;-)


--
Chuck Lever




      reply	other threads:[~2018-12-18 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 22:52 [PATCH v2 1/3] SUNRPC: Fix disconnection races Trond Myklebust
2018-12-17 22:52 ` [PATCH v2 2/3] SUNRPC: Fix a race with XPRT_CONNECTING Trond Myklebust
2018-12-17 22:52   ` [PATCH v2 3/3] SUNRPC: Remove xprt_connect_status() Trond Myklebust
2018-12-18 14:20 ` [PATCH v2 1/3] SUNRPC: Fix disconnection races Scott Mayhew
2018-12-18 15:55   ` Trond Myklebust
2018-12-18 15:59     ` Chuck Lever
2018-12-18 16:02       ` Trond Myklebust
2018-12-18 17:27         ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68DFAB69-180B-4B78-B4F3-EB7DD7B8152C@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=dwysocha@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).