From: "Su Yanjun <suyj.fnst@cn.fujitsu.com>" <suyj.fnst@cn.fujitsu.com>
To: <mora@netapp.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] CACHE: Fix test script as delegation being introduced
Date: Tue, 19 Feb 2019 09:00:01 +0800 [thread overview]
Message-ID: <694c9815-831f-ec96-2d18-13be63910dc1@cn.fujitsu.com> (raw)
In-Reply-To: <1548297019-9398-1-git-send-email-suyj.fnst@cn.fujitsu.com>
Any ping?
On 2019/1/24 10:30, Su Yanjun wrote:
> When we run nfstest_cache with nfsversion=4, it fails.
> As i know nfsv4 introduces delegation, so nfstest_cache runs fail since nfsv4.
>
> The test commandline is as below:
> ./nfstest_cache --nfsversion=4 -e /nfsroot --server 192.168.102.143 --client 192.168.102.142 --runtest acregmax_data --verbose all
>
> This patch adds compatible code for nfsv3 and nfsv4.
> When we test nfsv4, just use 'chmod' to recall delegation, then
> run the test. As 'chmod' will modify atime, so use 'noatime' mount option.
>
> Signed-off-by: Su Yanjun <suyj.fnst@cn.fujitsu.com>
> ---
> test/nfstest_cache | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/test/nfstest_cache b/test/nfstest_cache
> index 0838418..a31d48f 100755
> --- a/test/nfstest_cache
> +++ b/test/nfstest_cache
> @@ -165,8 +165,13 @@ class CacheTest(TestUtil):
> fd = None
> attr = 'data' if data_cache else 'attribute'
> header = "Verify consistency of %s caching with %s on a file" % (attr, self.nfsstr())
> +
> # Mount options
> - mtopts = "hard,intr,rsize=4096,wsize=4096"
> + if self.nfsversion >= 4:
> + mtopts = "noatime,hard,intr,rsize=4096,wsize=4096"
> + else:
> + mtopts = "hard,intr,rsize=4096,wsize=4096"
> +
> if actimeo:
> header += " actimeo = %d" % actimeo
> mtopts += ",actimeo=%d" % actimeo
> @@ -216,6 +221,11 @@ class CacheTest(TestUtil):
> if fstat.st_size != dlen:
> raise Exception("Size of newly created file is %d, should have been %d" %(fstat.st_size, dlen))
>
> + if self.nfsversion >= 4:
> + # revoke delegation
> + self.dprint('DBG3', "revoke delegation")
> + self.clientobj.run_cmd('chmod +x %s' % self.absfile)
> +
> if acregmax:
> # Stat the unchanging file until acregmax is hit
> # each stat doubles the valid cache time
next prev parent reply other threads:[~2019-02-19 1:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 2:30 [PATCH] CACHE: Fix test script as delegation being introduced Su Yanjun
2019-02-19 1:00 ` Su Yanjun <suyj.fnst@cn.fujitsu.com> [this message]
2019-04-08 2:47 Su Yanjun <suyj.fnst@cn.fujitsu.com>
2019-04-08 16:07 ` J. Bruce Fields
2019-07-03 1:34 [Problem]testOpenUpgradeLock test failed in nfsv4.0 in 5.2.0-rc7 Su Yanjun
2019-07-08 2:20 ` Su Yanjun
2019-07-08 13:48 ` Daniel Gryniewicz
2019-07-08 14:45 ` Frank Filz
2019-07-09 5:27 ` Su Yanjun
2019-07-29 1:54 ` [PATCH] CACHE: Fix test script as delegation being introduced Su Yanjun
2019-07-29 14:11 ` Olga Kornievskaia
[not found] <890610570fcd48d8b28b30e89f1f0038@G08CNEXMBPEKD05.g08.fujitsu.local>
2020-01-09 15:36 ` bfields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694c9815-831f-ec96-2d18-13be63910dc1@cn.fujitsu.com \
--to=suyj.fnst@cn.fujitsu.com \
--cc=linux-nfs@vger.kernel.org \
--cc=mora@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).