From: Trond Myklebust <trondmy@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Fix error return values for nfsd4_clone_file_range()
Date: Fri, 25 Jan 2019 00:50:09 -0500 [thread overview]
Message-ID: <698446e18a6718ee1ced06ecfd06e2de802fa16e.camel@gmail.com> (raw)
In-Reply-To: <20190125004658.GB3953@fieldses.org>
On Thu, 2019-01-24 at 19:46 -0500, J. Bruce Fields wrote:
> On Mon, Jan 21, 2019 at 03:58:38PM -0500, Trond Myklebust wrote:
> > If the parameter 'count' is non-zero, nfsd4_clone_file_range() will
> > currently clobber all errors returned by vfs_clone_file_range() and
> > replace them with EINVAL.
>
> Oops, thanks for the fix. I'm still a little confused, though:
>
> > Fixes: 42ec3d4c0218 ("vfs: make remap_file_range functions take
> > and...")
> > Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> > Cc: stable@vger.kernel.org # v4.20+
> > ---
> > fs/nfsd/vfs.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> > index 9824e32b2f23..7dc98e14655d 100644
> > --- a/fs/nfsd/vfs.c
> > +++ b/fs/nfsd/vfs.c
> > @@ -557,9 +557,11 @@ __be32 nfsd4_clone_file_range(struct file
> > *src, u64 src_pos, struct file *dst,
> > loff_t cloned;
> >
> > cloned = vfs_clone_file_range(src, src_pos, dst, dst_pos,
> > count, 0);
> > + if (cloned < 0)
> > + return nfserrno(cloned);
> > if (count && cloned != count)
> > - cloned = -EINVAL;
> > - return nfserrno(cloned < 0 ? cloned : 0);
> > + return nfserrno(-EINVAL);
> > + return 0;
>
> I still don't understand the cloned != count case. I thought clone
> was
> supposed to be all-or-nothing and atomic, can it really return a
> short
> copy? And how is that inval, shouldn't that be serverfault?
That, quite frankly, seems like more of a question for Darrick, not me.
I haven't changed that part of the code.
The main thing I care about is being able to correctly report
EOPNOTSUPP errors for the vast majority of filesystems that don't
support clone() or dedup().
Cheers
Trond
next prev parent reply other threads:[~2019-01-25 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 20:58 [PATCH] nfsd: Fix error return values for nfsd4_clone_file_range() Trond Myklebust
2019-01-25 0:46 ` J. Bruce Fields
2019-01-25 5:50 ` Trond Myklebust [this message]
2019-01-25 16:32 ` J. Bruce Fields
2019-01-25 16:42 ` Olga Kornievskaia
2019-01-25 20:10 ` J. Bruce Fields
2019-01-25 20:15 ` J. Bruce Fields
2019-01-25 20:57 ` Darrick J. Wong
2019-01-26 22:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698446e18a6718ee1ced06ecfd06e2de802fa16e.camel@gmail.com \
--to=trondmy@gmail.com \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).