From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F93C433E5 for ; Wed, 15 Jul 2020 15:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0B032072E for ; Wed, 15 Jul 2020 15:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728356AbgGOPIr convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2020 11:08:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50311 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728312AbgGOPIl (ORCPT ); Wed, 15 Jul 2020 11:08:41 -0400 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jvj1S-0003xS-HG for linux-nfs@vger.kernel.org; Wed, 15 Jul 2020 15:08:38 +0000 Received: by mail-pg1-f199.google.com with SMTP id u16so2942997pgj.17 for ; Wed, 15 Jul 2020 08:08:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PjMy4io7R2jHdSWxArusOtwgBaqFTbEYz/sY2JlYP5w=; b=AnAx3GxXihlP04QOx9uXTiB3cWiU2dRNhc/HfR3QymipG/FbBx156rUw/CApREpYVM zRs+6z5Ogq+mbrSk+WZRBfuMYqLOtDUOnmVBV+loGlpT/j/01QDePgGBqveuTglj3oH9 tHu9whjZQP0z6kBNIi/IhCZ+Rqk4lrh3Mhj94+06eKI4RuZ27mIhnV6ww9pH2zY1gcTM 8W9ybC6ZTSp3LvSbx3WxCu9+4SaLdGyDAcz4aAFKdw0a4CG1ff1RfLF//zK1hNUc/3PH nNR20Es57DyP8Jt1PhtYzuOrkvNYUEp44GED44xWLpWP09bueHsmiEUJzQpcXA9beDZY OFDQ== X-Gm-Message-State: AOAM5332ga84r673tRwzL7sNodKl6j5AlysRGyu2E/khB8AKEWP2CmW1 URMc5HV8EMkUUC9OZNtagcqziQL9LFkoQNqdUuhr249m2BDDBvo3DgdNR2DVhGhqXgHnNtgymbH e8Hy3lcq8m+Dxc0QLCsAAK8oYNSg+FYgcg31p0A== X-Received: by 2002:a17:90a:3002:: with SMTP id g2mr108795pjb.68.1594825717130; Wed, 15 Jul 2020 08:08:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeaLMdNxhmgRLyUdtuuy7GErTF8uag+bSGeUBRnl/y7/ExiAOI6J/b8SmUhYYGsqLrNQjV8w== X-Received: by 2002:a17:90a:3002:: with SMTP id g2mr108775pjb.68.1594825716853; Wed, 15 Jul 2020 08:08:36 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id 7sm2467724pgw.85.2020.07.15.08.08.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2020 08:08:36 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y From: Kai-Heng Feng In-Reply-To: <424D9E36-C51B-46E8-9A07-D329821F2647@oracle.com> Date: Wed, 15 Jul 2020 23:08:33 +0800 Cc: matthew.ruffell@canonical.com, linux-stable , Linux NFS Mailing List , "open list:NETWORKING DRIVERS" , open list Content-Transfer-Encoding: 8BIT Message-Id: <6E0D09F1-601B-432B-81EE-9858EC1AF1DE@canonical.com> References: <309E203B-8818-4E33-87F0-017E127788E2@canonical.com> <424D9E36-C51B-46E8-9A07-D329821F2647@oracle.com> To: Chuck Lever X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Jul 15, 2020, at 23:02, Chuck Lever wrote: > > > >> On Jul 15, 2020, at 10:48 AM, Kai-Heng Feng wrote: >> >> Hi, >> >> Multiple users reported NFS causes NULL pointer dereference [1] on Ubuntu, due to commit "SUNRPC: Add "@len" parameter to gss_unwrap()" and commit "SUNRPC: Fix GSS privacy computation of auth->au_ralign". >> >> The same issue happens on upstream stable 5.4.y branch. >> The mainline kernel doesn't have this issue though. >> >> Should we revert them? Or is there any missing commits need to be backported to v5.4? >> >> [1] https://bugs.launchpad.net/bugs/1886277 >> >> Kai-Heng > > 31c9590ae468 ("SUNRPC: Add "@len" parameter to gss_unwrap()") is a refactoring > change. It shouldn't have introduced any behavior difference. But in theory, > practice and theory should be the same... > > Check if 0a8e7b7d0846 ("SUNRPC: Revert 241b1f419f0e ("SUNRPC: Remove xdr_buf_trim()")") > is also applied to 5.4.0-40-generic. Yes, it's included. The commit is part of upstream stable 5.4. > > It would help to know if v5.5 stable is working for you. I haven't had any > problems with it. I'll ask users to test it out. Thanks for you quick reply! Kai-Heng > > > -- > Chuck Lever > > >