From: Steve Dickson <SteveD@RedHat.com>
To: NeilBrown <neilb@suse.de>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/5] nfs-utils: provide audit-logging of NFSv4 access
Date: Tue, 2 Mar 2021 15:41:14 -0500 [thread overview]
Message-ID: <6ddbe801-d107-5cbd-7362-c3e84321f203@RedHat.com> (raw)
In-Reply-To: <161422077024.28256.15543036625096419495.stgit@noble>
Hey!
A couple comments...
On 2/24/21 9:42 PM, NeilBrown wrote:
> When NFSv3 is used mountd provides logs of successful and failed mount
> attempts which can be used for auditing.
> When NFSv4 is used there are no such logs as NFSv4 does not have a
> distinct "mount" request.
>
> However mountd still knows about which filesysytems are being accessed
> from which clients, and can actually provide more reliable logs than it
> currently does, though they must be more verbose - with periodic "is
> being accessed" message replacing a single "was mounted" message.
>
> This series adds support for that logging, and adds some related
> improvements to make the logs as useful as possible.
>
> NeilBrown
>
> ---
>
> NeilBrown (5):
> mountd: reject unknown client IP when !use_ipaddr.
> mountd: Don't proactively add export info when fh info is requested.
> mountd: add logging for authentication results for accesses.
I wonder if we should mention setting "debug=auth" enables
this logging in the mountd manpage
> mountd: add --cache-use-ipaddr option to force use_ipaddr
> mountd: make default ttl settable by option
These two probably need to be put into the nfs.conf file
and the nfs.conf man page since the conf_get_num()
and conf_get_bool() calls were added.
Finally, I'll add this to my plate, but I'm thinking
the new log-auth and ttl flags probably should be
introduce into nfsv4.exported.
I didn't port over the use-ipaddr flag to exportd,
since I though it was only used in the v3 mount path
but may that was an oversight on my part.
Thoughts?
steved.
>
>
> support/export/auth.c | 4 +++
> support/export/cache.c | 32 +++++++++++------
> support/export/v4root.c | 3 +-
> support/include/exportfs.h | 3 +-
> support/nfs/exports.c | 4 ++-
> utils/mountd/mountd.c | 29 +++++++++++++++-
> utils/mountd/mountd.man | 70 ++++++++++++++++++++++++++++++++++++++
> 7 files changed, 130 insertions(+), 15 deletions(-)
>
> --
> Signature
>
next prev parent reply other threads:[~2021-03-03 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 2:42 [PATCH 0/5] nfs-utils: provide audit-logging of NFSv4 access NeilBrown
2021-02-25 2:42 ` [PATCH 5/5] mountd: make default ttl settable by option NeilBrown
2021-02-25 2:42 ` [PATCH 3/5] mountd: add logging for authentication results for accesses NeilBrown
2021-02-25 2:42 ` [PATCH 2/5] mountd: Don't proactively add export info when fh info is requested NeilBrown
2021-02-25 2:42 ` [PATCH 1/5] mountd: reject unknown client IP when !use_ipaddr NeilBrown
2021-02-25 2:42 ` [PATCH 4/5] mountd: add --cache-use-ipaddr option to force use_ipaddr NeilBrown
2021-03-02 20:41 ` Steve Dickson [this message]
2021-03-03 22:28 ` [PATCH 0/5] nfs-utils: provide audit-logging of NFSv4 access NeilBrown
2021-03-04 13:24 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddbe801-d107-5cbd-7362-c3e84321f203@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).