Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
@ 2019-05-08 14:58 Orion Poplawski
  2019-05-08 15:54 ` Steve Dickson
  0 siblings, 1 reply; 5+ messages in thread
From: Orion Poplawski @ 2019-05-08 14:58 UTC (permalink / raw)
  To: linux-nfs

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

This fixes:

/usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
please update the unit file accordingly.

Signed-off-by: Orion Poplawski <orion@nwra.com>
---
 systemd/nfs-blkmap.service | 2 +-
 systemd/rpc-statd.service  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
index 2bbcee6..6aa45ba 100644
--- a/systemd/nfs-blkmap.service
+++ b/systemd/nfs-blkmap.service
@@ -9,7 +9,7 @@ PartOf=nfs-utils.service

 [Service]
 Type=forking
-PIDFile=/var/run/blkmapd.pid
+PIDFile=/run/blkmapd.pid
 ExecStart=/usr/sbin/blkmapd

 [Install]
diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
index 3e92cf7..095629f 100644
--- a/systemd/rpc-statd.service
+++ b/systemd/rpc-statd.service
@@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
 [Service]
 Environment=RPC_STATD_NO_NOTIFY=1
 Type=forking
-PIDFile=/var/run/rpc.statd.pid
+PIDFile=/run/rpc.statd.pid
 ExecStart=/usr/sbin/rpc.statd
--
1.8.3.1

-- 
Orion Poplawski
Manager of NWRA Technical Systems          720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                 https://www.nwra.com/


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3799 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
  2019-05-08 14:58 [PATCH] nfs-utils: Change /var/run -> /run in systemd service files Orion Poplawski
@ 2019-05-08 15:54 ` Steve Dickson
  2019-05-08 16:02   ` Orion Poplawski
  0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2019-05-08 15:54 UTC (permalink / raw)
  To: Orion Poplawski, linux-nfs



On 5/8/19 10:58 AM, Orion Poplawski wrote:
> This fixes:
> 
> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
> please update the unit file accordingly.
Shouldn't the apps also be updated? I know there is a symbolic 
link... but just for completeness the pid files in both apps 
should be updated as well. 

steved.
> 
> Signed-off-by: Orion Poplawski <orion@nwra.com>
> ---
>  systemd/nfs-blkmap.service | 2 +-
>  systemd/rpc-statd.service  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
> index 2bbcee6..6aa45ba 100644
> --- a/systemd/nfs-blkmap.service
> +++ b/systemd/nfs-blkmap.service
> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
> 
>  [Service]
>  Type=forking
> -PIDFile=/var/run/blkmapd.pid
> +PIDFile=/run/blkmapd.pid
>  ExecStart=/usr/sbin/blkmapd
> 
>  [Install]
> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
> index 3e92cf7..095629f 100644
> --- a/systemd/rpc-statd.service
> +++ b/systemd/rpc-statd.service
> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>  [Service]
>  Environment=RPC_STATD_NO_NOTIFY=1
>  Type=forking
> -PIDFile=/var/run/rpc.statd.pid
> +PIDFile=/run/rpc.statd.pid
>  ExecStart=/usr/sbin/rpc.statd
> --
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
  2019-05-08 15:54 ` Steve Dickson
@ 2019-05-08 16:02   ` Orion Poplawski
  2019-05-09 17:25     ` Steve Dickson
  0 siblings, 1 reply; 5+ messages in thread
From: Orion Poplawski @ 2019-05-08 16:02 UTC (permalink / raw)
  To: Steve Dickson, linux-nfs

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

On 5/8/19 9:54 AM, Steve Dickson wrote:
> 
> 
> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>> This fixes:
>>
>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>> please update the unit file accordingly.
> Shouldn't the apps also be updated? I know there is a symbolic 
> link... but just for completeness the pid files in both apps 
> should be updated as well. 
> 
> steved.

I thought about that - but was concerned about legacy systems that still use
/var/run.

>>
>> Signed-off-by: Orion Poplawski <orion@nwra.com>
>> ---
>>  systemd/nfs-blkmap.service | 2 +-
>>  systemd/rpc-statd.service  | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>> index 2bbcee6..6aa45ba 100644
>> --- a/systemd/nfs-blkmap.service
>> +++ b/systemd/nfs-blkmap.service
>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>
>>  [Service]
>>  Type=forking
>> -PIDFile=/var/run/blkmapd.pid
>> +PIDFile=/run/blkmapd.pid
>>  ExecStart=/usr/sbin/blkmapd
>>
>>  [Install]
>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>> index 3e92cf7..095629f 100644
>> --- a/systemd/rpc-statd.service
>> +++ b/systemd/rpc-statd.service
>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>  [Service]
>>  Environment=RPC_STATD_NO_NOTIFY=1
>>  Type=forking
>> -PIDFile=/var/run/rpc.statd.pid
>> +PIDFile=/run/rpc.statd.pid
>>  ExecStart=/usr/sbin/rpc.statd
>> --
>> 1.8.3.1
>>


-- 
Orion Poplawski
Manager of NWRA Technical Systems          720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                 https://www.nwra.com/


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3799 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
  2019-05-08 16:02   ` Orion Poplawski
@ 2019-05-09 17:25     ` Steve Dickson
  2019-05-10 15:07       ` Steve Dickson
  0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2019-05-09 17:25 UTC (permalink / raw)
  To: Orion Poplawski, linux-nfs



On 5/8/19 12:02 PM, Orion Poplawski wrote:
> On 5/8/19 9:54 AM, Steve Dickson wrote:
>>
>>
>> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>>> This fixes:
>>>
>>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>>> please update the unit file accordingly.
>> Shouldn't the apps also be updated? I know there is a symbolic 
>> link... but just for completeness the pid files in both apps 
>> should be updated as well. 
>>
>> steved.
> 
> I thought about that - but was concerned about legacy systems that still use
> /var/run.
Any idea how long the symlink will be around? But I do see your point.

steved.

> 
>>>
>>> Signed-off-by: Orion Poplawski <orion@nwra.com>
>>> ---
>>>  systemd/nfs-blkmap.service | 2 +-
>>>  systemd/rpc-statd.service  | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>>> index 2bbcee6..6aa45ba 100644
>>> --- a/systemd/nfs-blkmap.service
>>> +++ b/systemd/nfs-blkmap.service
>>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>>
>>>  [Service]
>>>  Type=forking
>>> -PIDFile=/var/run/blkmapd.pid
>>> +PIDFile=/run/blkmapd.pid
>>>  ExecStart=/usr/sbin/blkmapd
>>>
>>>  [Install]
>>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>>> index 3e92cf7..095629f 100644
>>> --- a/systemd/rpc-statd.service
>>> +++ b/systemd/rpc-statd.service
>>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>>  [Service]
>>>  Environment=RPC_STATD_NO_NOTIFY=1
>>>  Type=forking
>>> -PIDFile=/var/run/rpc.statd.pid
>>> +PIDFile=/run/rpc.statd.pid
>>>  ExecStart=/usr/sbin/rpc.statd
>>> --
>>> 1.8.3.1
>>>
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
  2019-05-09 17:25     ` Steve Dickson
@ 2019-05-10 15:07       ` Steve Dickson
  0 siblings, 0 replies; 5+ messages in thread
From: Steve Dickson @ 2019-05-10 15:07 UTC (permalink / raw)
  To: Orion Poplawski, linux-nfs



On 5/9/19 1:25 PM, Steve Dickson wrote:
> 
> 
> On 5/8/19 12:02 PM, Orion Poplawski wrote:
>> On 5/8/19 9:54 AM, Steve Dickson wrote:
>>>
>>>
>>> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>>>> This fixes:
>>>>
>>>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>>>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>>>> please update the unit file accordingly.
>>> Shouldn't the apps also be updated? I know there is a symbolic 
>>> link... but just for completeness the pid files in both apps 
>>> should be updated as well. 
>>>
>>> steved.
>>
>> I thought about that - but was concerned about legacy systems that still use
>> /var/run.
> Any idea how long the symlink will be around? But I do see your point.
> 
> steved.
> 
>>
>>>>
>>>> Signed-off-by: Orion Poplawski <orion@nwra.com>
>>>> ---
>>>>  systemd/nfs-blkmap.service | 2 +-
>>>>  systemd/rpc-statd.service  | 2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
Committed.... 

steved.

>>>>
>>>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>>>> index 2bbcee6..6aa45ba 100644
>>>> --- a/systemd/nfs-blkmap.service
>>>> +++ b/systemd/nfs-blkmap.service
>>>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>>>
>>>>  [Service]
>>>>  Type=forking
>>>> -PIDFile=/var/run/blkmapd.pid
>>>> +PIDFile=/run/blkmapd.pid
>>>>  ExecStart=/usr/sbin/blkmapd
>>>>
>>>>  [Install]
>>>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>>>> index 3e92cf7..095629f 100644
>>>> --- a/systemd/rpc-statd.service
>>>> +++ b/systemd/rpc-statd.service
>>>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>>>  [Service]
>>>>  Environment=RPC_STATD_NO_NOTIFY=1
>>>>  Type=forking
>>>> -PIDFile=/var/run/rpc.statd.pid
>>>> +PIDFile=/run/rpc.statd.pid
>>>>  ExecStart=/usr/sbin/rpc.statd
>>>> --
>>>> 1.8.3.1
>>>>
>>
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 14:58 [PATCH] nfs-utils: Change /var/run -> /run in systemd service files Orion Poplawski
2019-05-08 15:54 ` Steve Dickson
2019-05-08 16:02   ` Orion Poplawski
2019-05-09 17:25     ` Steve Dickson
2019-05-10 15:07       ` Steve Dickson

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox