From: Chuck Lever <chuck.lever@oracle.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: matthew.ruffell@canonical.com,
linux-stable <stable@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y
Date: Wed, 15 Jul 2020 11:14:52 -0400 [thread overview]
Message-ID: <7042081C-27B3-4024-BA34-7146B459F8B4@oracle.com> (raw)
In-Reply-To: <6E0D09F1-601B-432B-81EE-9858EC1AF1DE@canonical.com>
> On Jul 15, 2020, at 11:08 AM, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>
>> On Jul 15, 2020, at 23:02, Chuck Lever <chuck.lever@oracle.com> wrote:
>>
>>> On Jul 15, 2020, at 10:48 AM, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>>
>>> Hi,
>>>
>>> Multiple users reported NFS causes NULL pointer dereference [1] on Ubuntu, due to commit "SUNRPC: Add "@len" parameter to gss_unwrap()" and commit "SUNRPC: Fix GSS privacy computation of auth->au_ralign".
>>>
>>> The same issue happens on upstream stable 5.4.y branch.
>>> The mainline kernel doesn't have this issue though.
>>>
>>> Should we revert them? Or is there any missing commits need to be backported to v5.4?
>>>
>>> [1] https://bugs.launchpad.net/bugs/1886277
>>>
>>> Kai-Heng
>>
>> 31c9590ae468 ("SUNRPC: Add "@len" parameter to gss_unwrap()") is a refactoring
>> change. It shouldn't have introduced any behavior difference. But in theory,
>> practice and theory should be the same...
>>
>> Check if 0a8e7b7d0846 ("SUNRPC: Revert 241b1f419f0e ("SUNRPC: Remove xdr_buf_trim()")")
>> is also applied to 5.4.0-40-generic.
>
> Yes, it's included. The commit is part of upstream stable 5.4.
>
>>
>> It would help to know if v5.5 stable is working for you. I haven't had any
>> problems with it.
>
> I'll ask users to test it out.
> Thanks for you quick reply!
Another thought: Please ask what encryption type is in use. The
kerberos_v1 enctypes might exercise a code path I wasn't able to
test.
--
Chuck Lever
next prev parent reply other threads:[~2020-07-15 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 14:48 [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y Kai-Heng Feng
2020-07-15 15:02 ` Chuck Lever
2020-07-15 15:08 ` Kai-Heng Feng
2020-07-15 15:14 ` Chuck Lever [this message]
2020-07-15 18:54 ` Chuck Lever
2020-07-16 18:40 ` Pierre Sauter
2020-07-16 19:25 ` Chuck Lever
2020-07-17 17:29 ` Pierre Sauter
2020-07-17 17:34 ` Chuck Lever
2020-07-17 17:56 ` Kai-Heng Feng
2020-07-17 19:46 ` Pierre Sauter
2020-07-18 15:55 ` Chuck Lever
2020-07-20 21:22 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7042081C-27B3-4024-BA34-7146B459F8B4@oracle.com \
--to=chuck.lever@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=matthew.ruffell@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).