From: Steve Dickson <SteveD@RedHat.com>
To: Petr Vorel <petr.vorel@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH 1/1] mountd: Fix compilation for --disable-uuid
Date: Mon, 18 Nov 2019 11:30:14 -0500 [thread overview]
Message-ID: <73a7f1f5-4a02-4711-7826-6d82d08ac96b@RedHat.com> (raw)
In-Reply-To: <20191118143147.26015-1-petr.vorel@gmail.com>
On 11/18/19 9:31 AM, Petr Vorel wrote:
> Although code in configure.ac pretends to set USE_BLKID as 0
> via AC_DEFINE_UNQUOTED, it's actually not defined
> support/include/config.h.in
> support/include/config.h
> /* #undef USE_BLKID */
>
> Fixes: 8e643554 ("Allow disabling of libblkid usage.")
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
Committed! Thanks!! (tag: nfs-utils-2-4-3-rc1)
steved.
> ---
> utils/mountd/cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index 31e9507d..e5186c78 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -221,7 +221,7 @@ static void auth_unix_gid(int f)
> xlog(L_ERROR, "auth_unix_gid: error writing reply");
> }
>
> -#if USE_BLKID
> +#ifdef USE_BLKID
> static const char *get_uuid_blkdev(char *path)
> {
> /* We set *safe if we know that we need the
>
prev parent reply other threads:[~2019-11-18 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 14:31 [nfs-utils PATCH 1/1] mountd: Fix compilation for --disable-uuid Petr Vorel
2019-11-18 16:30 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a7f1f5-4a02-4711-7826-6d82d08ac96b@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).