linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Olga Kornievskaia <aglo@umich.edu>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: rdma compile error
Date: Wed, 4 Dec 2019 13:25:01 -0500	[thread overview]
Message-ID: <7D6BD48C-E6B3-43D4-8A31-99F0B387EF77@oracle.com> (raw)
In-Reply-To: <CAN-5tyEPhcE6NBktsqRKySyAUi6EeC_saWFH8A7tKFZ+Sb0jMg@mail.gmail.com>



> On Dec 4, 2019, at 1:12 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> 
> On Wed, Dec 4, 2019 at 1:02 PM Chuck Lever <chuck.lever@oracle.com> wrote:
>> 
>> Hi Olga-
>> 
>>> On Dec 4, 2019, at 11:15 AM, Olga Kornievskaia <aglo@umich.edu> wrote:
>>> 
>>> Hi Chuck,
>>> 
>>> I git cloned your origin/cel-testing, it's on the following commit.
>>> commit 37e235c0128566e9d97741ad1e546b44f324f108
>>> Author: Chuck Lever <chuck.lever@oracle.com>
>>> Date:   Fri Nov 29 12:06:00 2019 -0500
>>> 
>>>   xprtrdma: Invoke rpcrdma_ep_create() in the connect worker
>>> 
>>> And I'm getting the following compile error.
>>> 
>>> CC [M]  drivers/infiniband/core/cma_trace.o
>>> In file included from drivers/infiniband/core/cma_trace.h:302:0,
>>>                from drivers/infiniband/core/cma_trace.c:16:
>>> ./include/trace/define_trace.h:95:43: fatal error: ./cma_trace.h: No
>>> such file or directory
>>> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>>>                                          ^
>>> Is this known?
>> 
>> I haven't had any complaints from lkp.
>> 
>> f73179592745 ("RDMA/cma: Add trace points in RDMA Connection Manager")
>> 
>> should have added drivers/infiniband/core/cma_trace.h .
>> 
> 
> The file "cma_trace.h" is there in the "core" directory. But for some
> reason my compile expects it to be in include/trace directory (if I
> were to copy it there I can compile).

The end of cma_trace.h should have:

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH .
#define TRACE_INCLUDE_FILE cma_trace

That is supposed to steer the compiler to the cma_trace.h in core/ .

Does a "make mrproper; git clean -d -f -x" help? Feels like there's
a stale generated file somewhere that's breaking things.


--
Chuck Lever




  reply	other threads:[~2019-12-04 18:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 16:15 rdma compile error Olga Kornievskaia
2019-12-04 18:01 ` Chuck Lever
2019-12-04 18:12   ` Olga Kornievskaia
2019-12-04 18:25     ` Chuck Lever [this message]
2019-12-04 19:09       ` Olga Kornievskaia
2019-12-19 15:57         ` Chuck Lever
2019-12-19 16:10           ` Olga Kornievskaia
2020-01-06 21:01             ` Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7D6BD48C-E6B3-43D4-8A31-99F0B387EF77@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=aglo@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).