From: Chuck Lever <chuck.lever@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org,
linux-cifs@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH v3] rdma: Enable ib_alloc_cq to spread work over a device's comp_vectors
Date: Mon, 5 Aug 2019 13:15:22 -0400 [thread overview]
Message-ID: <87D288BC-65F8-4678-A8C5-DEF7C3355BC7@oracle.com> (raw)
In-Reply-To: <f181b5b6-df7c-d657-4ec6-4a4e56a9b5ff@acm.org>
Hi Bart-
> On Aug 5, 2019, at 12:09 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 7/29/19 10:22 AM, Chuck Lever wrote:
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1a039f1..e25c70a 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -1767,8 +1767,8 @@ static int srpt_create_ch_ib(struct srpt_rdma_ch *ch)
>> goto out;
>> retry:
>> - ch->cq = ib_alloc_cq(sdev->device, ch, ch->rq_size + sq_size,
>> - 0 /* XXX: spread CQs */, IB_POLL_WORKQUEUE);
>> + ch->cq = ib_alloc_cq_any(sdev->device, ch, ch->rq_size + sq_size,
>> + IB_POLL_WORKQUEUE);
>> if (IS_ERR(ch->cq)) {
>> ret = PTR_ERR(ch->cq);
>> pr_err("failed to create CQ cqe= %d ret= %d\n",
> Hi Chuck,
>
> Please Cc me for future srp and srpt patches. I think my name appears next to both drivers in the MAINTAINERS file.
I see your name listed, but I thought the rule was to Cc: the mailing list
which is listed for that component. My bad.
--
Chuck Lever
prev parent reply other threads:[~2019-08-05 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 17:22 [PATCH v3] rdma: Enable ib_alloc_cq to spread work over a device's comp_vectors Chuck Lever
2019-08-05 16:02 ` Doug Ledford
2019-08-05 16:09 ` Bart Van Assche
2019-08-05 17:15 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87D288BC-65F8-4678-A8C5-DEF7C3355BC7@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).