From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>, <bfields@fieldses.org>,
<jlayton@poochiereds.net>, <trond.myklebust@primarydata.com>,
<davem@davemloft.net>, <linux-nfs@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <julia.lawall@lip6.fr>
Subject: Re: [PATCH] sunrpc: Remove unnecessary variable
Date: Mon, 8 Aug 2016 09:49:56 -0400 [thread overview]
Message-ID: <8822c3be-56c1-d9ac-7f7d-164804322083@Netapp.com> (raw)
In-Reply-To: <20160808091349.GA20849@amitoj-Inspiron-3542>
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote:
> The variable `err` is not used anywhere and just returns the
> predefined value `0` at the end of the function. Hence, remove the
> variable and return 0 explicitly.
Makes sense to me. Thanks!
Anna
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> net/sunrpc/clnt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index b7f2104..0a775fa 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> struct super_block *sb)
> {
> struct dentry *dentry;
> - int err = 0;
>
> switch (event) {
> case RPC_PIPEFS_MOUNT:
> @@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
> return -ENOTSUPP;
> }
> - return err;
> + return 0;
> }
>
> static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
>
prev parent reply other threads:[~2016-08-08 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 9:13 [PATCH] sunrpc: Remove unnecessary variable Amitoj Kaur Chawla
2016-08-08 13:49 ` Anna Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8822c3be-56c1-d9ac-7f7d-164804322083@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=amitoj1606@gmail.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=jlayton@poochiereds.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).