From: Jeff Layton <jlayton@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-nfs <linux-nfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
chuck lever <chuck.lever@oracle.com>, anna <anna@kernel.org>,
trond myklebust <trond.myklebust@hammerspace.com>,
Al Viro <viro@zeniv.linux.org.uk>, raven <raven@themaw.net>,
chris chilvers <chris.chilvers@appsbroker.com>,
david young <david.young@appsbroker.com>,
luis turcitu <luis.turcitu@appsbroker.com>,
david <david@sigma-star.at>
Subject: Re: [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto mounts
Date: Mon, 28 Nov 2022 06:49:36 -0500 [thread overview]
Message-ID: <8ca382fa391a08313ba8dc5ce115e1832e32aebb.camel@kernel.org> (raw)
In-Reply-To: <1045320558.283423.1669584585412.JavaMail.zimbra@nod.at>
On Sun, 2022-11-27 at 22:29 +0100, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
> > Von: "Jeff Layton" <jlayton@kernel.org>
> > > So, in nfsd_cross_mnt() the follow_down() helper should use LOOKUP_AUTOMOUNT
> > > only
> > > if exp->ex_flags & NFSEXP_CROSSMOUNT is true?
> > > Sounds sane, thanks for the pointer.
> > >
> >
> > Yeah, I think so. I do wonder if we ought to make any provision for
> > "nohide" exports, but since you have to enumerate those explicitly, it
> > shouldn't be a huge problem for someone to just ensure that they're
> > mounted beforehand.
>
> TBH, I didn't invest much into the nohide feature wrt. NFS re-exporting.
> What problem do you have in mind?
>
nohide is sort of complimentary to crossmnt. You can achieve the same
effect as crossmnt by adding explicit exports for all the children and
marking them "nohide".
The point here is that you have to explicitly create exports for the
child mounts in that case, and if you're doing that then it's not a
burden for the admin to make sure they're mounted before exporting.
So, I don't think we need to worry about nohide here after all.
> I wonder also what NFS client folks think about my changes before I send
> the next revision (with Jeff's comments addressed).
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-11-28 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 19:11 [PATCH 0/3] NFS: NFSD: Allow crossing mounts when re-exporting Richard Weinberger
2022-11-17 19:11 ` [PATCH 1/3] NFSD: Teach nfsd_mountpoint() auto mounts Richard Weinberger
2022-11-17 19:11 ` [PATCH 2/3] fs: namei: Allow follow_down() to uncover " Richard Weinberger
2022-11-17 21:01 ` Jeff Layton
2022-11-17 21:12 ` Richard Weinberger
2022-11-17 21:42 ` Jeff Layton
2022-11-27 21:29 ` Richard Weinberger
2022-11-28 11:49 ` Jeff Layton [this message]
2022-11-17 23:37 ` Ian Kent
2022-11-17 19:11 ` [PATCH 3/3] NFS: nfs_encode_fh: Remove S_AUTOMOUNT check Richard Weinberger
2022-12-07 8:43 [PATCH 0/3 v2] NFS: NFSD: Allow crossing mounts when re-exporting Richard Weinberger
2022-12-07 8:43 ` [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto mounts Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ca382fa391a08313ba8dc5ce115e1832e32aebb.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=chris.chilvers@appsbroker.com \
--cc=chuck.lever@oracle.com \
--cc=david.young@appsbroker.com \
--cc=david@sigma-star.at \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luis.turcitu@appsbroker.com \
--cc=raven@themaw.net \
--cc=richard@nod.at \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).