From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Weston Andros Adamson <dros@netapp.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: fix getacl ERANGE for some ACL buffer sizes
Date: Sat, 16 Nov 2013 20:12:04 +0000 [thread overview]
Message-ID: <910547E4-9A70-4258-92C4-233D9DC1C169@netapp.com> (raw)
In-Reply-To: <E1BD19D4-40C6-456D-A6EE-73D3BA2F1E4B@netapp.com>
On Nov 16, 2013, at 14:15, Weston Andros Adamson <dros@netapp.com> wrote:
> I'm going to rethink this, as the server may return arbitrarily long bitmaps.
>
> I'll probably just always allocate an extra page...
Perhaps we should do the same thing for NFSv4 that we do in nfs3_proc_getacl and just have xdr_partial_copy_from_skb allocate the pages for us?
Cheers
Trond
next prev parent reply other threads:[~2013-11-16 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 15:02 [PATCH] NFSv4: fix getacl ERANGE for some ACL buffer sizes Weston Andros Adamson
2013-11-16 19:15 ` Weston Andros Adamson
2013-11-16 20:12 ` Myklebust, Trond [this message]
2013-11-21 14:33 ` Weston Andros Adamson
2013-11-21 14:56 ` Myklebust, Trond
2013-11-21 15:38 ` Weston Andros Adamson
2013-11-21 21:20 [PATCH v2] " Weston Andros Adamson
2015-12-14 22:18 ` J. Bruce Fields
2015-12-14 22:21 ` [PATCH] " J. Bruce Fields
2015-12-14 23:27 ` Trond Myklebust
2015-12-15 14:04 ` J. Bruce Fields
2015-12-23 16:58 ` J. Bruce Fields
2015-12-24 1:37 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910547E4-9A70-4258-92C4-233D9DC1C169@netapp.com \
--to=trond.myklebust@netapp.com \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).