From: Chuck Lever <chuck.lever@oracle.com>
To: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-rdma <linux-rdma@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Subject: Re: [PATCH v3] xprtrdma: Make sure Send CQ is allocated on an existing compvec
Date: Tue, 5 Feb 2019 12:23:01 -0500 [thread overview]
Message-ID: <91CC910C-48A1-4234-8347-39D1A710A87C@oracle.com> (raw)
In-Reply-To: <9d418664-1f67-c705-19a0-80fc9dc5a12b@suse.com>
> On Feb 5, 2019, at 12:21 PM, Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com> wrote:
>
> Make sure the device has at least 2 completion vectors
> before allocating to compvec#1
>
> Fixes: a4699f5647f3 (xprtrdma: Put Send CQ in IB_POLL_WORKQUEUE mode)
> Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Anna, can you see that this fix gets into v5.0-rc ? Thanks!
> ---
> Changes since v2:
> - Split line for checkpatch to be happy
>
> net/sunrpc/xprtrdma/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index b725911c0f3f..5fe727a7db82 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -546,7 +546,8 @@ rpcrdma_ep_create(struct rpcrdma_ep *ep, struct rpcrdma_ia *ia,
>
> sendcq = ib_alloc_cq(ia->ri_device, NULL,
> ep->rep_attr.cap.max_send_wr + 1,
> - 1, IB_POLL_WORKQUEUE);
> + ia->ri_device->num_comp_vectors > 1 ? 1 : 0,
> + IB_POLL_WORKQUEUE);
> if (IS_ERR(sendcq)) {
> rc = PTR_ERR(sendcq);
> dprintk("RPC: %s: failed to create send CQ: %i\n",
> --
> 2.18.0
--
Chuck Lever
next prev parent reply other threads:[~2019-02-05 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 17:21 [PATCH v3] xprtrdma: Make sure Send CQ is allocated on an existing compvec Nicolas Morey-Chaisemartin
2019-02-05 17:23 ` Chuck Lever [this message]
2019-02-12 14:35 ` Nicolas Morey-Chaisemartin
2019-02-12 20:32 ` Schumaker, Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91CC910C-48A1-4234-8347-39D1A710A87C@oracle.com \
--to=chuck.lever@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nmoreychaisemartin@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).