From: Trond Myklebust <trondmy@hammerspace.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"ito_kazuo_g3@lab.ntt.co.jp" <ito_kazuo_g3@lab.ntt.co.jp>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"konishi.ryusuke@lab.ntt.co.jp" <konishi.ryusuke@lab.ntt.co.jp>,
"watanabe.hiroyuki@lab.ntt.co.jp"
<watanabe.hiroyuki@lab.ntt.co.jp>
Subject: Re: [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement
Date: Thu, 21 Feb 2019 22:33:30 +0000 [thread overview]
Message-ID: <9bb9ab1c96002db928babf5d2dc8ad9315325fbc.camel@hammerspace.com> (raw)
In-Reply-To: <92b9e2a4-8880-3fc6-1f6a-e5ab85ed96e6@lab.ntt.co.jp>
On Thu, 2019-02-14 at 18:34 +0900, Kazuo Ito wrote:
> This set of patches attempt to fix potential data integrity problem
> in nfs_want_read_modify_write() and improve full page overwrite
> performance of pNFS block/SCSI layouts.
>
> The patch set comprises of two patches:
> - 1/2 "pNFS: Fix potential corruption of page being written"
> fixes the integrity issue
> - 2/2 "pNFS: Avoid read/modify/write when it is not necessary"
> addresses the cases where read/modify/write was requested for a
> full-
> page write.
>
> v1 -> v2:
> - added the fix for missing PagePrivate in the pNFS block layout
> - made the check for full page write a separate inline function
> - merged the duplicated code for the pNFS block/SCSI layouts and
> for the other layout + normal NFS
> - type usage clean up (int to bool, unsigned to unsigned int)
>
> kazuo ito (2):
> pNFS: Fix potential corruption of page being written
> pNFS: Avoid read/modify/write when it is not necessary
>
> fs/nfs/file.c | 40 ++++++++++++++++++++++++++--------------
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
These look good so I've applied them to the linux-next branch for the
5.1 merge window,
Thanks!
Trond
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2019-02-21 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 9:34 [PATCH v2 0/2] pNFS block/SCSI layouts read-modify-write fix&improvement Kazuo Ito
2019-02-21 22:33 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb9ab1c96002db928babf5d2dc8ad9315325fbc.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=ito_kazuo_g3@lab.ntt.co.jp \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-nfs@vger.kernel.org \
--cc=watanabe.hiroyuki@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).