From: "Benjamin Coddington" <bcodding@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "Chuck Lever" <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd4: kill warnings on testing stateids with mismatched clientids
Date: Thu, 19 Mar 2020 10:30:53 -0400 [thread overview]
Message-ID: <A2752AC8-E6FF-4ED7-86BE-4D64ACE1F7D7@redhat.com> (raw)
In-Reply-To: <20200319141849.GB1546@fieldses.org>
On 19 Mar 2020, at 10:18, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> It's normal for a client to test a stateid from a previous instance,
> e.g. after a network partition.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Thanks!
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Ben
> ---
> fs/nfsd/nfs4state.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> I'm not a fan of printk's even on buggy client behavior. I guess it
> could be a dprintk. I'm not sure it adds much over information you
> could get at some other layer, e.g. from a network trace.
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c1f347bbf8f4..927cfb9d2204 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5522,15 +5522,8 @@ static __be32 nfsd4_validate_stateid(struct
> nfs4_client *cl, stateid_t *stateid)
> if (ZERO_STATEID(stateid) || ONE_STATEID(stateid) ||
> CLOSE_STATEID(stateid))
> return status;
> - /* Client debugging aid. */
> - if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid)) {
> - char addr_str[INET6_ADDRSTRLEN];
> - rpc_ntop((struct sockaddr *)&cl->cl_addr, addr_str,
> - sizeof(addr_str));
> - pr_warn_ratelimited("NFSD: client %s testing state ID "
> - "with incorrect client ID\n", addr_str);
> + if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid))
> return status;
> - }
> spin_lock(&cl->cl_lock);
> s = find_stateid_locked(cl, stateid);
> if (!s)
> --
> 2.25.1
next prev parent reply other threads:[~2020-03-19 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 14:18 [PATCH] nfsd4: kill warnings on testing stateids with mismatched clientids J. Bruce Fields
2020-03-19 14:30 ` Benjamin Coddington [this message]
2020-03-19 14:59 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2752AC8-E6FF-4ED7-86BE-4D64ACE1F7D7@redhat.com \
--to=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).