From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@hammerspace.com>
Cc: anna.schumaker@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Don't use page_file_mapping after removing the page
Date: Tue, 05 Feb 2019 05:23:08 -0500 [thread overview]
Message-ID: <B7217157-4540-43E9-A355-C38A0EEC1FAA@redhat.com> (raw)
In-Reply-To: <602aa0cc867676254cf09d6e329eb6a8f7345920.camel@hammerspace.com>
On 4 Feb 2019, at 16:40, Trond Myklebust wrote:
> What about the case when the page is in the swap cache? Is that also
> safe?
I think the case you'd like me to consider is when a file on NFS has its
mapping backed by pages that are in swap. In that case, it makes no sense
to check the count of pages in the swap file's mapping to determine whether
to set NFS_INO_INVALID_DATA. We actually want to optimize away the
revalidation if the NFS file lacks mapped pages.
Ben
next prev parent reply other threads:[~2019-02-05 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:13 [PATCH] NFS: Don't use page_file_mapping after removing the page Benjamin Coddington
2019-02-04 18:32 ` Trond Myklebust
2019-02-04 19:03 ` Benjamin Coddington
2019-02-04 19:07 ` Benjamin Coddington
2019-02-04 19:20 ` Benjamin Coddington
2019-02-04 20:31 ` Benjamin Coddington
2019-02-04 21:40 ` Trond Myklebust
2019-02-05 10:23 ` Benjamin Coddington [this message]
2019-02-06 11:12 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7217157-4540-43E9-A355-C38A0EEC1FAA@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).